From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/dp/mst: don't pass port into the path builder function
Date: Wed, 30 Sep 2015 09:22:07 +0200 [thread overview]
Message-ID: <20150930072207.GV3383@phenom.ffwll.local> (raw)
In-Reply-To: <1442366532-23024-1-git-send-email-airlied@gmail.com>
On Wed, Sep 16, 2015 at 11:22:11AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This is unnecessary and it makes it easier to see what is needed
> from port.
>
> also add blank line to make things nicer.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index e23df5f..87112d3 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1027,8 +1027,8 @@ static void drm_dp_check_port_guid(struct drm_dp_mst_branch *mstb,
> }
> }
>
> -static void build_mst_prop_path(struct drm_dp_mst_port *port,
> - struct drm_dp_mst_branch *mstb,
> +static void build_mst_prop_path(const struct drm_dp_mst_branch *mstb,
> + int pnum,
> char *proppath,
> size_t proppath_size)
> {
> @@ -1041,7 +1041,7 @@ static void build_mst_prop_path(struct drm_dp_mst_port *port,
> snprintf(temp, sizeof(temp), "-%d", port_num);
> strlcat(proppath, temp, proppath_size);
> }
> - snprintf(temp, sizeof(temp), "-%d", port->port_num);
> + snprintf(temp, sizeof(temp), "-%d", pnum);
> strlcat(proppath, temp, proppath_size);
> }
>
> @@ -1113,7 +1113,8 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
>
> if (created && !port->input) {
> char proppath[255];
> - build_mst_prop_path(port, mstb, proppath, sizeof(proppath));
> +
> + build_mst_prop_path(mstb, port->port_num, proppath, sizeof(proppath));
> port->connector = (*mstb->mgr->cbs->add_connector)(mstb->mgr, port, proppath);
>
> if (port->port_num >= 8) {
> --
> 2.4.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-09-30 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 1:22 [PATCH 1/2] drm/dp/mst: don't pass port into the path builder function Dave Airlie
2015-09-16 1:22 ` [PATCH 2/2] drm/dp/mst: fixup handling hotplug on port removal Dave Airlie
2015-09-30 7:30 ` Daniel Vetter
2015-09-30 7:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930072207.GV3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.