From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/dp_mst: make functions that always return 0 return void. Date: Wed, 30 Sep 2015 09:33:33 +0200 Message-ID: <20150930073333.GY3383@phenom.ffwll.local> References: <1441529580-7899-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8FC596EB89 for ; Wed, 30 Sep 2015 00:30:39 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so183851590wic.0 for ; Wed, 30 Sep 2015 00:30:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441529580-7899-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMDYsIDIwMTUgYXQgMDY6NTI6NTlQTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gVGhpcyBqdXN0IGRyb3BzIHRoZSByZXR1cm4gYW5kIGFzc2lnbmluZyBpdCB0byBhIGxl biB2YXJpYWJsZQo+IHRoYXQgbmV2ZXIgZ2V0cyB1c2VkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERh dmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f ZHBfbXN0X3RvcG9sb2d5LmMgfCAyOSArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gaW5kZXggZTIzZGY1Zi4uMjk0ZDkwNCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IEBAIC02MzEsNyArNjMx LDcgQEAgc3RhdGljIGJvb2wgZHJtX2RwX3NpZGViYW5kX3BhcnNlX3JlcShzdHJ1Y3QgZHJtX2Rw X3NpZGViYW5kX21zZ19yeCAqcmF3LAo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGJ1aWxk X2RwY2Rfd3JpdGUoc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfdHggKm1zZywgdTggcG9ydF9u dW0sIHUzMiBvZmZzZXQsIHU4IG51bV9ieXRlcywgdTggKmJ5dGVzKQo+ICtzdGF0aWMgdm9pZCBi dWlsZF9kcGNkX3dyaXRlKHN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3R4ICptc2csIHU4IHBv cnRfbnVtLCB1MzIgb2Zmc2V0LCB1OCBudW1fYnl0ZXMsIHU4ICpieXRlcykKPiAgewo+ICAJc3Ry dWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfcmVxX2JvZHkgcmVxOwo+ICAKPiBAQCAtNjQxLDIwICs2 NDEsMTcgQEAgc3RhdGljIGludCBidWlsZF9kcGNkX3dyaXRlKHN0cnVjdCBkcm1fZHBfc2lkZWJh bmRfbXNnX3R4ICptc2csIHU4IHBvcnRfbnVtLCB1MzIKPiAgCXJlcS51LmRwY2Rfd3JpdGUubnVt X2J5dGVzID0gbnVtX2J5dGVzOwo+ICAJcmVxLnUuZHBjZF93cml0ZS5ieXRlcyA9IGJ5dGVzOwo+ ICAJZHJtX2RwX2VuY29kZV9zaWRlYmFuZF9yZXEoJnJlcSwgbXNnKTsKPiAtCj4gLQlyZXR1cm4g MDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBidWlsZF9saW5rX2FkZHJlc3Moc3RydWN0IGRybV9k cF9zaWRlYmFuZF9tc2dfdHggKm1zZykKPiArc3RhdGljIHZvaWQgYnVpbGRfbGlua19hZGRyZXNz KHN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3R4ICptc2cpCj4gIHsKPiAgCXN0cnVjdCBkcm1f ZHBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5IHJlcTsKPiAgCj4gIAlyZXEucmVxX3R5cGUgPSBEUF9M SU5LX0FERFJFU1M7Cj4gIAlkcm1fZHBfZW5jb2RlX3NpZGViYW5kX3JlcSgmcmVxLCBtc2cpOwo+ IC0JcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgYnVpbGRfZW51bV9wYXRoX3Jlc291 cmNlcyhzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ190eCAqbXNnLCBpbnQgcG9ydF9udW0pCj4g K3N0YXRpYyB2b2lkIGJ1aWxkX2VudW1fcGF0aF9yZXNvdXJjZXMoc3RydWN0IGRybV9kcF9zaWRl YmFuZF9tc2dfdHggKm1zZywgaW50IHBvcnRfbnVtKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RwX3Np ZGViYW5kX21zZ19yZXFfYm9keSByZXE7Cj4gIAo+IEBAIC02NjIsMTAgKzY1OSw5IEBAIHN0YXRp YyBpbnQgYnVpbGRfZW51bV9wYXRoX3Jlc291cmNlcyhzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21z Z190eCAqbXNnLCBpbnQgcG9yCj4gIAlyZXEudS5wb3J0X251bS5wb3J0X251bWJlciA9IHBvcnRf bnVtOwo+ICAJZHJtX2RwX2VuY29kZV9zaWRlYmFuZF9yZXEoJnJlcSwgbXNnKTsKPiAgCW1zZy0+ cGF0aF9tc2cgPSB0cnVlOwo+IC0JcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgYnVp bGRfYWxsb2NhdGVfcGF5bG9hZChzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ190eCAqbXNnLCBp bnQgcG9ydF9udW0sCj4gK3N0YXRpYyB2b2lkIGJ1aWxkX2FsbG9jYXRlX3BheWxvYWQoc3RydWN0 IGRybV9kcF9zaWRlYmFuZF9tc2dfdHggKm1zZywgaW50IHBvcnRfbnVtLAo+ICAJCQkJICB1OCB2 Y3BpLCB1aW50MTZfdCBwYm4pCj4gIHsKPiAgCXN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3Jl cV9ib2R5IHJlcTsKPiBAQCAtNjc2LDcgKzY3Miw2IEBAIHN0YXRpYyBpbnQgYnVpbGRfYWxsb2Nh dGVfcGF5bG9hZChzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ190eCAqbXNnLCBpbnQgcG9ydF9u Cj4gIAlyZXEudS5hbGxvY2F0ZV9wYXlsb2FkLnBibiA9IHBibjsKPiAgCWRybV9kcF9lbmNvZGVf c2lkZWJhbmRfcmVxKCZyZXEsIG1zZyk7Cj4gIAltc2ctPnBhdGhfbXNnID0gdHJ1ZTsKPiAtCXJl dHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGRybV9kcF9tc3RfYXNzaWduX3BheWxvYWRf aWQoc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gQEAgLTE0NjEsNyArMTQ1 Niw2IEBAIHN0YXRpYyB2b2lkIGRybV9kcF9xdWV1ZV9kb3duX3R4KHN0cnVjdCBkcm1fZHBfbXN0 X3RvcG9sb2d5X21nciAqbWdyLAo+ICBzdGF0aWMgaW50IGRybV9kcF9zZW5kX2xpbmtfYWRkcmVz cyhzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9tZ3IgKm1nciwKPiAgCQkJCSAgICBzdHJ1Y3Qg ZHJtX2RwX21zdF9icmFuY2ggKm1zdGIpCj4gIHsKPiAtCWludCBsZW47Cj4gIAlzdHJ1Y3QgZHJt X2RwX3NpZGViYW5kX21zZ190eCAqdHhtc2c7Cj4gIAlpbnQgcmV0Owo+ICAKPiBAQCAtMTQ3MCw3 ICsxNDY0LDcgQEAgc3RhdGljIGludCBkcm1fZHBfc2VuZF9saW5rX2FkZHJlc3Moc3RydWN0IGRy bV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJ dHhtc2ctPmRzdCA9IG1zdGI7Cj4gLQlsZW4gPSBidWlsZF9saW5rX2FkZHJlc3ModHhtc2cpOwo+ ICsJYnVpbGRfbGlua19hZGRyZXNzKHR4bXNnKTsKPiAgCj4gIAlkcm1fZHBfcXVldWVfZG93bl90 eChtZ3IsIHR4bXNnKTsKPiAgCj4gQEAgLTE1MTAsNyArMTUwNCw2IEBAIHN0YXRpYyBpbnQgZHJt X2RwX3NlbmRfZW51bV9wYXRoX3Jlc291cmNlcyhzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9t Z3IgKm1nciwKPiAgCQkJCQkgICBzdHJ1Y3QgZHJtX2RwX21zdF9icmFuY2ggKm1zdGIsCj4gIAkJ CQkJICAgc3RydWN0IGRybV9kcF9tc3RfcG9ydCAqcG9ydCkKPiAgewo+IC0JaW50IGxlbjsKPiAg CXN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3R4ICp0eG1zZzsKPiAgCWludCByZXQ7Cj4gIAo+ IEBAIC0xNTE5LDcgKzE1MTIsNyBAQCBzdGF0aWMgaW50IGRybV9kcF9zZW5kX2VudW1fcGF0aF9y ZXNvdXJjZXMoc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gIAkJcmV0dXJu IC1FTk9NRU07Cj4gIAo+ICAJdHhtc2ctPmRzdCA9IG1zdGI7Cj4gLQlsZW4gPSBidWlsZF9lbnVt X3BhdGhfcmVzb3VyY2VzKHR4bXNnLCBwb3J0LT5wb3J0X251bSk7Cj4gKwlidWlsZF9lbnVtX3Bh dGhfcmVzb3VyY2VzKHR4bXNnLCBwb3J0LT5wb3J0X251bSk7Cj4gIAo+ICAJZHJtX2RwX3F1ZXVl X2Rvd25fdHgobWdyLCB0eG1zZyk7Cj4gIAo+IEBAIC0xNTQ3LDcgKzE1NDAsNyBAQCBzdGF0aWMg aW50IGRybV9kcF9wYXlsb2FkX3NlbmRfbXNnKHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21n ciAqbWdyLAo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ190eCAqdHhtc2c7Cj4g IAlzdHJ1Y3QgZHJtX2RwX21zdF9icmFuY2ggKm1zdGI7Cj4gLQlpbnQgbGVuLCByZXQ7Cj4gKwlp bnQgcmV0Owo+ICAKPiAgCW1zdGIgPSBkcm1fZHBfZ2V0X3ZhbGlkYXRlZF9tc3RiX3JlZihtZ3Is IHBvcnQtPnBhcmVudCk7Cj4gIAlpZiAoIW1zdGIpCj4gQEAgLTE1NjAsOSArMTU1Myw4IEBAIHN0 YXRpYyBpbnQgZHJtX2RwX3BheWxvYWRfc2VuZF9tc2coc3RydWN0IGRybV9kcF9tc3RfdG9wb2xv Z3lfbWdyICptZ3IsCj4gIAl9Cj4gIAo+ICAJdHhtc2ctPmRzdCA9IG1zdGI7Cj4gLQlsZW4gPSBi dWlsZF9hbGxvY2F0ZV9wYXlsb2FkKHR4bXNnLCBwb3J0LT5wb3J0X251bSwKPiAtCQkJCSAgICAg aWQsCj4gLQkJCQkgICAgIHBibik7Cj4gKwlidWlsZF9hbGxvY2F0ZV9wYXlsb2FkKHR4bXNnLCBw b3J0LT5wb3J0X251bSwKPiArCQkJICAgICAgIGlkLCBwYm4pOwo+ICAKPiAgCWRybV9kcF9xdWV1 ZV9kb3duX3R4KG1nciwgdHhtc2cpOwo+ICAKPiBAQCAtMTc3Miw3ICsxNzY0LDYgQEAgc3RhdGlj IGludCBkcm1fZHBfc2VuZF9kcGNkX3dyaXRlKHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21n ciAqbWdyLAo+ICAJCQkJICBzdHJ1Y3QgZHJtX2RwX21zdF9wb3J0ICpwb3J0LAo+ICAJCQkJICBp bnQgb2Zmc2V0LCBpbnQgc2l6ZSwgdTggKmJ5dGVzKQo+ICB7Cj4gLQlpbnQgbGVuOwo+ICAJaW50 IHJldDsKPiAgCXN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3R4ICp0eG1zZzsKPiAgCXN0cnVj dCBkcm1fZHBfbXN0X2JyYW5jaCAqbXN0YjsKPiBAQCAtMTc4Nyw3ICsxNzc4LDcgQEAgc3RhdGlj IGludCBkcm1fZHBfc2VuZF9kcGNkX3dyaXRlKHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21n ciAqbWdyLAo+ICAJCWdvdG8gZmFpbF9wdXQ7Cj4gIAl9Cj4gIAo+IC0JbGVuID0gYnVpbGRfZHBj ZF93cml0ZSh0eG1zZywgcG9ydC0+cG9ydF9udW0sIG9mZnNldCwgc2l6ZSwgYnl0ZXMpOwo+ICsJ YnVpbGRfZHBjZF93cml0ZSh0eG1zZywgcG9ydC0+cG9ydF9udW0sIG9mZnNldCwgc2l6ZSwgYnl0 ZXMpOwo+ICAJdHhtc2ctPmRzdCA9IG1zdGI7Cj4gIAo+ICAJZHJtX2RwX3F1ZXVlX2Rvd25fdHgo bWdyLCB0eG1zZyk7Cj4gLS0gCj4gMi40LjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5n aW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==