From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755086AbbI3JHH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 05:07:07 -0400
Received: from mail.skyhub.de ([78.46.96.112]:48223 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754241AbbI3JHB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 05:07:01 -0400
Date: Wed, 30 Sep 2015 11:06:20 +0200
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Andrey Konovalov <andreyknvl@google.com>,
        Kostya Serebryany <kcc@google.com>,
        Alexander Potapenko <glider@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        x86@kernel.org, Dmitry Vyukov <dvyukov@google.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>
Subject: Re: [patch 0/2] x86/process: Sanitize bound checks in get_wchan()
 and unify 32/64 bit
Message-ID: <20150930090620.GC6033@pd.tnic>
References: <20150930082754.401022511@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150930082754.401022511@linutronix.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 30, 2015 at 08:38:21AM -0000, Thomas Gleixner wrote:
> As reported by several people the bound checks in get_wchan() on x86/64bit
> are wrong.
> 
> The following series addresses that problem and as a consequence
> unifies the needlessly different implementations of 32 and 64 bit.
> 
> Thanks,
> 
> 	tglx
> 
> ---
>  process.c    |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  process_32.c |   28 ----------------------------
>  process_64.c |   24 ------------------------
>  3 files changed, 55 insertions(+), 52 deletions(-)

Hohumm, looks good to me. Especially the documentation of the stack
layout and why we're doing all that dance.

Reviewed-by: Borislav Petkov <bp@suse.de>

Should we CC: stable?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.