From: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
To: yu.dai@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Don't forward flip interrupts to GuC
Date: Wed, 30 Sep 2015 10:16:14 -0700 [thread overview]
Message-ID: <20150930171614.GA22166@torourke-desk1> (raw)
In-Reply-To: <1443632257-14309-1-git-send-email-yu.dai@intel.com>
On Wed, Sep 30, 2015 at 09:57:37AM -0700, yu.dai@intel.com wrote:
> From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>
> Due to flip interrupts GuC stays awake always and GT does not enter
> RC6. Do not route those interrupts to GuC for now. Driver won't touch
> DE_GUCRMR register and leave it as what default value.
>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Alex Dai <yu.dai@intel.com>
[TOR:] This patch was previously sent. Still looks good to me.
Reviewed-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc_loader.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
> index ae85366..934b003 100644
> --- a/drivers/gpu/drm/i915/intel_guc_loader.c
> +++ b/drivers/gpu/drm/i915/intel_guc_loader.c
> @@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)
> for_each_ring(ring, dev_priv, i)
> I915_WRITE(RING_MODE_GEN7(ring), irqs);
>
> - /* tell DE to send nothing to GuC */
> - I915_WRITE(DE_GUCRMR, ~0);
> -
> /* route all GT interrupts to the host */
> I915_WRITE(GUC_BCS_RCS_IER, 0);
> I915_WRITE(GUC_VCS2_VCS1_IER, 0);
> @@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)
> for_each_ring(ring, dev_priv, i)
> I915_WRITE(RING_MODE_GEN7(ring), irqs);
>
> - /* tell DE to send (all) flip_done to GuC */
> - irqs = DERRMR_PIPEA_PRI_FLIP_DONE | DERRMR_PIPEA_SPR_FLIP_DONE |
> - DERRMR_PIPEB_PRI_FLIP_DONE | DERRMR_PIPEB_SPR_FLIP_DONE |
> - DERRMR_PIPEC_PRI_FLIP_DONE | DERRMR_PIPEC_SPR_FLIP_DONE;
> - /* Unmasked bits will cause GuC response message to be sent */
> - I915_WRITE(DE_GUCRMR, ~irqs);
> -
> /* route USER_INTERRUPT to Host, all others are sent to GuC. */
> irqs = GT_RENDER_USER_INTERRUPT << GEN8_RCS_IRQ_SHIFT |
> GT_RENDER_USER_INTERRUPT << GEN8_BCS_IRQ_SHIFT;
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-30 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 16:57 [PATCH] drm/i915/guc: Don't forward flip interrupts to GuC yu.dai
2015-09-30 17:16 ` O'Rourke, Tom [this message]
2015-10-01 8:18 ` Daniel Vetter
2015-10-01 8:52 ` Jani Nikula
2015-10-01 9:30 ` Daniel Vetter
2015-10-01 9:51 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930171614.GA22166@torourke-desk1 \
--to=tom.o'rourke@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yu.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.