From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932974AbbI3SMN (ORCPT ); Wed, 30 Sep 2015 14:12:13 -0400 Received: from bes.se.axis.com ([195.60.68.10]:50640 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbbI3SML (ORCPT ); Wed, 30 Sep 2015 14:12:11 -0400 Date: Wed, 30 Sep 2015 20:11:54 +0200 From: Jesper Nilsson To: Jesper Nilsson Cc: Andy Shevchenko , Jesper Nilsson , Mikael Starvik , linux-cris-kernel , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Subject: Re: [PATCH] cris: kgdb: use native hex2bin Message-ID: <20150930181154.GA4919@axis.com> References: <1370335914-31582-1-git-send-email-andriy.shevchenko@linux.intel.com> <1443624413.8361.305.camel@linux.intel.com> <20150930152224.GZ4919@axis.com> <1443627471.8361.314.camel@linux.intel.com> <20150930180234.GA6732@jni.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930180234.GA6732@jni.nu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 08:02:34PM +0200, Jesper Nilsson wrote: > On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote: > > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > > > > There are kernel native helpers to convert hex ascii to the > > > > > binary > > > > > format: > > > > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them > > > > > customly. > > > > > > > > > > > > > No one is interested in this? > > > > > > Hm, dunno why, but obviously I've missed these patches, > > > and I can't find them on my main mailaccount either. > > > > > > Anyways, I found them on a secondary account, and have > > > added them to the CRIS linux-next tree. > > > > Just noticed that it was along time ago and currently it might produce > > compile warnings or errors since now hex2bin is prefixed by > > __must_check. > > > > Would you like me to send v2? > > Unless you've tweaked them more since you sent them, > it shouldn't be necessary, the patches applied cleanly. > Those (most) files in CRIS are not touched very often... :-) ... and now I saw your v2, I'll take that instead since you already fixed the __must_check problems. Thanks a lot! > > Andy Shevchenko /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com