All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	eranian@google.com, naveen.n.rao@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
Date: Wed, 30 Sep 2015 21:09:09 +0200	[thread overview]
Message-ID: <20150930190909.GA27570@krava.redhat.com> (raw)
In-Reply-To: <20150930182836.GA27858@us.ibm.com>

On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote:
> From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Thu, 24 Sep 2015 17:53:49 -0400
> Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
> 
> perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false.
> So the weak definition for 'sample_regs_masks' doesn't get picked up.
> 
> Adding perf_regs.o to util/Build unconditionally, exposes a redefinition
> error for 'perf_reg_value()' function (due to the static inline version
> in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> function.
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  reply	other threads:[~2015-09-30 19:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 18:28 [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks Sukadev Bhattiprolu
2015-09-30 19:09 ` Jiri Olsa [this message]
2015-09-30 19:45   ` Arnaldo Carvalho de Melo
2015-10-07  0:46     ` Michael Ellerman
2015-10-07 13:19       ` Arnaldo Carvalho de Melo
2015-10-01  7:11 ` [tip:perf/core] perf tools: " tip-bot for Sukadev Bhattiprolu
2015-10-07 16:36 ` [tip:perf/urgent] " tip-bot for Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930190909.GA27570@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.