All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH] perf report: Fix a bug on "--call-graph none" option
Date: Wed, 30 Sep 2015 19:03:15 -0300	[thread overview]
Message-ID: <20150930220315.GN1944@kernel.org> (raw)
In-Reply-To: <1443587640-24242-1-git-send-email-namhyung@kernel.org>

Em Wed, Sep 30, 2015 at 01:34:00PM +0900, Namhyung Kim escreveu:
> The patch f9db0d0f1b2c ("perf callchain: Allow disabling call graphs
> per event") added an ability to enable/disable callchain recording per
> event.  But it had a problem when the enablement setting is changed at
> 'perf report' time using -g/--call-graph option.
> 
> For example, the following scenario will get a segfault.
> 
>   $ perf record -ag sleep 1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.500 MB perf.data (2555 samples) ]
> 
>   $ perf report -g none
>   perf: Segmentation fault
>   -------- backtrace --------
>   perf[0x53a98a]
>   /usr/lib/libc.so.6(+0x335af)[0x7f4e91df95af]
> 
> This is because callchain_param.sort() callback was not set but it
> tried to call the function as it had the PERF_SAMPLE_CALLCHAIN bit.

Thanks, reproduced, tested the fix, applied.

- Arnaldo

  reply	other threads:[~2015-09-30 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  4:34 [PATCH] perf report: Fix a bug on "--call-graph none" option Namhyung Kim
2015-09-30 22:03 ` Arnaldo Carvalho de Melo [this message]
2015-10-03  7:49 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930220315.GN1944@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.