All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Neutron Soutmun <neo.neutron@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libmnl: Failed to build with clang, incompatible EXPORT_SYMBOL(x) macro
Date: Thu, 1 Oct 2015 00:12:41 +0200	[thread overview]
Message-ID: <20150930221241.GA14943@salvia> (raw)
In-Reply-To: <20150925040745.GA433@oxygen>

On Fri, Sep 25, 2015 at 11:07:45AM +0700, Neutron Soutmun wrote:
> The EXPORT_SYMBOL(x) macro causes clang compile error and warning
> messges:
>   error,   "note: previous definition is here"
>   warning, "warning: attribute declaration must precede definition
>             [-Wignored-attributes]"
>   See: [1]
> 
> This proposed patch has been prepared to fix this error which make the
> EXPORT_SYMBOL macro define a precede definition of an attribute
> declaration. This approach is both compatible with gcc and clang.

We have more libraries using this approach, which resembles kernel
coding. So we would need to update them all, which is a bit annoying.

Though this warning results in a real problem since symbols will not
be exported.

Why is clang rejecting this?

  reply	other threads:[~2015-09-30 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25  4:07 [PATCH] libmnl: Failed to build with clang, incompatible EXPORT_SYMBOL(x) macro Neutron Soutmun
2015-09-30 22:12 ` Pablo Neira Ayuso [this message]
2015-10-01  3:15   ` Neutron Soutmun
2015-10-01  9:20   ` Jan Engelhardt
2015-10-01  9:30     ` Neutron Soutmun
2015-10-01 10:15       ` Pablo Neira Ayuso
2015-10-01 10:29         ` Neutron Soutmun
2015-10-01 11:12           ` Neutron Soutmun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930221241.GA14943@salvia \
    --to=pablo@netfilter.org \
    --cc=neo.neutron@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.