Re: [Outreachy kernel] [PATCH] Staging: android: Remove unneeded definition in header file

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Oct 01, 2015 at 09:49:26AM +0530, Shraddha Barke wrote:
> These struct are globally defined in source file but they have been
> defined as static in .h file. Remove definition in header file as
> it is not needed. Also fix the compiler warning.
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/android/sw_sync.h | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/drivers/staging/android/sw_sync.h b/drivers/staging/android/sw_sync.h
> index c87ae9e..a671595 100644
> --- a/drivers/staging/android/sw_sync.h
> +++ b/drivers/staging/android/sw_sync.h
> @@ -39,21 +39,6 @@ struct sw_sync_timeline *sw_sync_timeline_create(const char *name);
>  void sw_sync_timeline_inc(struct sw_sync_timeline *obj, u32 inc);
>  
>  struct sync_pt *sw_sync_pt_create(struct sw_sync_timeline *obj, u32 value);
> -#else
> -static inline struct sw_sync_timeline *sw_sync_timeline_create(const char *name)
> -{
> -	return NULL;
> -}
> -
> -static inline void sw_sync_timeline_inc(struct sw_sync_timeline *obj, u32 inc)
> -{
> -}
> -
> -static inline struct sync_pt *sw_sync_pt_create(struct sw_sync_timeline *obj,
> -						u32 value)
> -{
> -	return NULL;
> -}
>  #endif /* IS_ENABLED(CONFIG_SW_SYNC) */
>  
>  #endif /* _LINUX_SW_SYNC_H */

You just broke the build for systems that don't define CONFIG_SW_SYNC
yet still call these functions :(

Yes, it's tricky as there are no in-kernel users of these functions,
that's the joy of the android code, external, out-of-tree code depends
on the in-kernel code right now due to not everything being merged yet.

So, sorry, I can't take this patch.

greg k-h