All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32
Date: Thu, 1 Oct 2015 10:23:33 +0200	[thread overview]
Message-ID: <20151001082333.GA1486@gmail.com> (raw)
In-Reply-To: <1443660043.2730.15.camel@decadent.org.uk>


* Ben Hutchings <ben@decadent.org.uk> wrote:

> diff --git a/arch/x86/include/uapi/asm/bitsperlong.h b/arch/x86/include/uapi/asm/bitsperlong.h
> index b0ae1c4..217909b 100644
> --- a/arch/x86/include/uapi/asm/bitsperlong.h
> +++ b/arch/x86/include/uapi/asm/bitsperlong.h
> @@ -1,7 +1,7 @@
>  #ifndef __ASM_X86_BITSPERLONG_H
>  #define __ASM_X86_BITSPERLONG_H
>  
> -#ifdef __x86_64__
> +#if defined(__x86_64__) && !defined(__ILP32__)
>  # define __BITS_PER_LONG 64

Can we write this as:

   #ifdef __ILP64__

?

Thanks,

	Ingo

  reply	other threads:[~2015-10-01  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01  0:40 [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 Ben Hutchings
2015-10-01  8:23 ` Ingo Molnar [this message]
2015-10-01 13:02   ` Brian Gerst
2015-10-01 20:54     ` Ben Hutchings
2015-10-02  1:52       ` Ben Hutchings
2015-10-02  7:45 ` [tip:x86/urgent] x86/headers/uapi: Fix __BITS_PER_LONG value for x32 builds tip-bot for Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001082333.GA1486@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ben@decadent.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.