From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com ([209.85.212.169]:34482 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbJAKPF (ORCPT ); Thu, 1 Oct 2015 06:15:05 -0400 Received: by wicfx3 with SMTP id fx3so25464319wic.1 for ; Thu, 01 Oct 2015 03:15:03 -0700 (PDT) Date: Thu, 1 Oct 2015 12:17:58 +0200 From: Daniel Vetter Subject: Re: [PATCH] drm: Hack around CONFIG_AGP=m build failures Message-ID: <20151001101757.GV3383@phenom.ffwll.local> References: <1443682119-17011-1-git-send-email-daniel.vetter@ffwll.ch> <8737xvc87a.fsf@intel.com> <560D03C8.70309@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560D03C8.70309@suse.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Michal Marek Cc: Jani Nikula , Daniel Vetter , DRI Development , Stephen Rothwell , linux-kbuild@vger.kernel.org, Daniel Vetter On Thu, Oct 01, 2015 at 11:58:32AM +0200, Michal Marek wrote: > On 2015-10-01 10:19, Jani Nikula wrote: > > On Thu, 01 Oct 2015, Daniel Vetter wrote: > >> Surprisingly kbuild can't cope with tristates in the > >> -$(CONFIG_FOO) pattern. This patch hacks up a solution. > > > > Given that it's two distinct Makefile variables (foo-y and foo-m) being > > assigned to, I don't really find this surprising. Maybe this could be > > made to work as a convenience, but there might be other, more surpising > > consequences. > > I actually think that kbuild should be able to handle this. The likely > reason why it is not doing it right now is that in an ideal world, > modules are modules can be built out of tree against just the kernel and > their static dependencies. In real world, we sometimes have features in > modules that are enabled if other modules are enabled. I'll post a patch > later. We also have lots of tests fo CONFIG_FOO || CONFIG_FOO_MODULE in > built-in code, which is a similar case. Cool. I'll keep this hack in drm-misc then. Please cc me on the proper solution so I know when I can revert it again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Hack around CONFIG_AGP=m build failures Date: Thu, 1 Oct 2015 12:17:58 +0200 Message-ID: <20151001101757.GV3383@phenom.ffwll.local> References: <1443682119-17011-1-git-send-email-daniel.vetter@ffwll.ch> <8737xvc87a.fsf@intel.com> <560D03C8.70309@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4FC76E147 for ; Thu, 1 Oct 2015 03:15:04 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so21007755wic.1 for ; Thu, 01 Oct 2015 03:15:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <560D03C8.70309@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michal Marek Cc: Stephen Rothwell , linux-kbuild@vger.kernel.org, Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMDEsIDIwMTUgYXQgMTE6NTg6MzJBTSArMDIwMCwgTWljaGFsIE1hcmVrIHdy b3RlOgo+IE9uIDIwMTUtMTAtMDEgMTA6MTksIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gT24gVGh1 LCAwMSBPY3QgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3Jv dGU6Cj4gPj4gU3VycHJpc2luZ2x5IGtidWlsZCBjYW4ndCBjb3BlIHdpdGggdHJpc3RhdGVzIGlu IHRoZQo+ID4+IDxtb2R1bGU+LSQoQ09ORklHX0ZPTykgcGF0dGVybi4gVGhpcyBwYXRjaCBoYWNr cyB1cCBhIHNvbHV0aW9uLgo+ID4gCj4gPiBHaXZlbiB0aGF0IGl0J3MgdHdvIGRpc3RpbmN0IE1h a2VmaWxlIHZhcmlhYmxlcyAoZm9vLXkgYW5kIGZvby1tKSBiZWluZwo+ID4gYXNzaWduZWQgdG8s IEkgZG9uJ3QgcmVhbGx5IGZpbmQgdGhpcyBzdXJwcmlzaW5nLiBNYXliZSB0aGlzIGNvdWxkIGJl Cj4gPiBtYWRlIHRvIHdvcmsgYXMgYSBjb252ZW5pZW5jZSwgYnV0IHRoZXJlIG1pZ2h0IGJlIG90 aGVyLCBtb3JlIHN1cnBpc2luZwo+ID4gY29uc2VxdWVuY2VzLgo+IAo+IEkgYWN0dWFsbHkgdGhp bmsgdGhhdCBrYnVpbGQgc2hvdWxkIGJlIGFibGUgdG8gaGFuZGxlIHRoaXMuIFRoZSBsaWtlbHkK PiByZWFzb24gd2h5IGl0IGlzIG5vdCBkb2luZyBpdCByaWdodCBub3cgaXMgdGhhdCBpbiBhbiBp ZGVhbCB3b3JsZCwKPiBtb2R1bGVzIGFyZSBtb2R1bGVzIGNhbiBiZSBidWlsdCBvdXQgb2YgdHJl ZSBhZ2FpbnN0IGp1c3QgdGhlIGtlcm5lbCBhbmQKPiB0aGVpciBzdGF0aWMgZGVwZW5kZW5jaWVz LiBJbiByZWFsIHdvcmxkLCB3ZSBzb21ldGltZXMgaGF2ZSBmZWF0dXJlcyBpbgo+IG1vZHVsZXMg dGhhdCBhcmUgZW5hYmxlZCBpZiBvdGhlciBtb2R1bGVzIGFyZSBlbmFibGVkLiBJJ2xsIHBvc3Qg YSBwYXRjaAo+IGxhdGVyLiBXZSBhbHNvIGhhdmUgbG90cyBvZiB0ZXN0cyBmbyBDT05GSUdfRk9P IHx8IENPTkZJR19GT09fTU9EVUxFIGluCj4gYnVpbHQtaW4gY29kZSwgd2hpY2ggaXMgYSBzaW1p bGFyIGNhc2UuCgpDb29sLiBJJ2xsIGtlZXAgdGhpcyBoYWNrIGluIGRybS1taXNjIHRoZW4uIFBs ZWFzZSBjYyBtZSBvbiB0aGUgcHJvcGVyCnNvbHV0aW9uIHNvIEkga25vdyB3aGVuIEkgY2FuIHJl dmVydCBpdCBhZ2Fpbi4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK