From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932832AbbJALRV (ORCPT ); Thu, 1 Oct 2015 07:17:21 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38001 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754292AbbJALRS (ORCPT ); Thu, 1 Oct 2015 07:17:18 -0400 Date: Thu, 1 Oct 2015 12:17:13 +0100 From: Lee Jones To: Richard Fitzgerald Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6 RESEND] mfd: arizona: Downgrade type mismatch messages to dev_warn Message-ID: <20151001111713.GN3214@x1> References: <1443444406-30518-1-git-send-email-rf@opensource.wolfsonmicro.com> <1443444406-30518-4-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443444406-30518-4-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2015, Richard Fitzgerald wrote: > If the declared codec type doesn't match the detected type > we issue a log message but carry on registering the device, > so a dev_warn() is appropriate rather than a dev_err() > > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/arizona-core.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) For my own reference: Acked-by: Lee Jones > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 73d26dd..cb09172 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -1132,8 +1132,8 @@ int arizona_dev_init(struct arizona *arizona) > case 0x5102: > type_name = "WM5102"; > if (arizona->type != WM5102) { > - dev_err(arizona->dev, "WM5102 registered as %d\n", > - arizona->type); > + dev_warn(arizona->dev, "WM5102 registered as %d\n", > + arizona->type); > arizona->type = WM5102; > } > apply_patch = wm5102_patch; > @@ -1151,8 +1151,8 @@ int arizona_dev_init(struct arizona *arizona) > break; > default: > type_name = "WM5110"; > - dev_err(arizona->dev, "WM5110 registered as %d\n", > - arizona->type); > + dev_warn(arizona->dev, "WM5110 registered as %d\n", > + arizona->type); > arizona->type = WM5110; > break; > } > @@ -1163,8 +1163,8 @@ int arizona_dev_init(struct arizona *arizona) > case 0x8997: > type_name = "WM8997"; > if (arizona->type != WM8997) { > - dev_err(arizona->dev, "WM8997 registered as %d\n", > - arizona->type); > + dev_warn(arizona->dev, "WM8997 registered as %d\n", > + arizona->type); > arizona->type = WM8997; > } > apply_patch = wm8997_patch; > @@ -1183,8 +1183,8 @@ int arizona_dev_init(struct arizona *arizona) > > default: > type_name = "WM8998"; > - dev_err(arizona->dev, "WM8998 registered as %d\n", > - arizona->type); > + dev_warn(arizona->dev, "WM8998 registered as %d\n", > + arizona->type); > arizona->type = WM8998; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog