From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 118B61A0B63 for ; Thu, 1 Oct 2015 22:28:11 +1000 (AEST) Date: Thu, 1 Oct 2015 14:28:02 +0200 From: Peter Zijlstra To: Boqun Feng Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Will Deacon , "Paul E. McKenney" , Waiman Long Subject: Re: [RFC v2 6/7] powerpc: atomic: Make atomic{,64}_xchg and xchg a full barrier Message-ID: <20151001122802.GR2881@worktop.programming.kicks-ass.net> References: <1442418575-12297-1-git-send-email-boqun.feng@gmail.com> <1442418575-12297-7-git-send-email-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1442418575-12297-7-git-send-email-boqun.feng@gmail.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 16, 2015 at 11:49:34PM +0800, Boqun Feng wrote: > According to memory-barriers.txt, xchg and its atomic{,64}_ versions > need to imply a full barrier, however they are now just RELEASE+ACQUIRE, > which is not a full barrier. > > So remove the definition of xchg(), and let __atomic_op_fence() build > the full-barrier versions of these operations. Do you want to do a patch for -stable fixing the current implementation?