From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ronit Halder <ronit.crj@gmail.com>
Cc: Lidza Louina <lidza.louina@gmail.com>,
devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
DaeSeok Youn <daeseok.youn@gmail.com>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()
Date: Thu, 1 Oct 2015 18:04:50 +0300 [thread overview]
Message-ID: <20151001150450.GE7289@mwanda> (raw)
In-Reply-To: <CAAm8cU7Y0t5xDLuY1SrNq9UjT6+3bDskZtXWUYb2-1u89fGMRQ@mail.gmail.com>
On Thu, Oct 01, 2015 at 09:11:31AM +0530, Ronit Halder wrote:
> The existing dgap_parsefile() rejects invalid config file.
> But before we know that config file is invalid a lot of memory leak
> can happen. Removing the chances of memory leak won't heart anyone.
>
Why not just reject it earlier instead of allocating more data?
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-01 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 6:09 [PATCH] staging: dgap: fix memory leak in dgap_parsefile() Ronit Halder
2015-09-30 11:48 ` Dan Carpenter
2015-10-01 3:41 ` Ronit Halder
2015-10-01 15:04 ` Dan Carpenter [this message]
2015-10-01 15:16 ` Ronit Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001150450.GE7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ronit.crj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.