All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: 64 bit bug in bxtwc_val_store()
Date: Thu, 01 Oct 2015 15:23:19 +0000	[thread overview]
Message-ID: <20151001152319.GE3214@x1> (raw)
In-Reply-To: <20150928095636.GB11367@mwanda>

On Thu, 01 Oct 2015, Dan Carpenter wrote:
> On Thu, Oct 01, 2015 at 06:13:31PM +0300, Dan Carpenter wrote:
> > I looked at the subjects to every other patch to that file and I
> > followed the same pattern.
> 
> This is literally a part of my kpatch.sh script:
> 
> git log --oneline $fullname | head -n 10
> echo "Copy and paste one of these subjects?"
> read unused

Okay, this is good.  Unfortunately I guess process over-ruled common
sense on this occasion (meant more of a joke than offensively). ;)

When new drivers are sent, the patch format is more likely to be:

  mfd: "Adding new driver for ..."

As there is no <device> to mention.  However, as yours is an add-on
patch which makes changes to an existing driver, a better subject
line would have been:

  mfd: <device>: "I'm doing this"

... but I completely understand the confusion.  Not much to change
then, keep doing what you're doing.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-10-01 15:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  9:56 [patch] mfd: 64 bit bug in bxtwc_val_store() Dan Carpenter
2015-10-01 11:51 ` Lee Jones
2015-10-01 15:13 ` Dan Carpenter
2015-10-01 15:16 ` Dan Carpenter
2015-10-01 15:23 ` Lee Jones [this message]
2015-10-01 15:35 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001152319.GE3214@x1 \
    --to=lee.jones@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.