From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735AbbJAQNq (ORCPT ); Thu, 1 Oct 2015 12:13:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbbJAQNo (ORCPT ); Thu, 1 Oct 2015 12:13:44 -0400 Date: Thu, 1 Oct 2015 13:13:40 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Peter Zijlstra , Stephane Eranian , linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, cel@us.ibm.com, dsahern@gmail.com, adrian.hunter@intel.com, johnmccutchan@google.com, brendan.d.gregg@gmail.com Subject: Re: [PATCH v7 0/4] perf: add support for profiling jitted code Message-ID: <20151001161340.GB12682@redhat.com> References: <1443681949-6534-1-git-send-email-eranian@google.com> <20151001091736.GO2881@worktop.programming.kicks-ass.net> <20151001093914.GA9546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151001093914.GA9546@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Oct 01, 2015 at 11:39:14AM +0200, Ingo Molnar escreveu: > * Peter Zijlstra wrote: > > > This will also generate an ELF image for each jitted function. The injected > > > MMAP records will point to these ELF images. The reasoning behind using ELF > > > images is that it makes processing for perf report and annotate automatic and > > > transparent. It also makes it easier to package and analyze on a remote > > > machine. Binutils tools can decode the ELF images easily. > > The generation of ELF files is really nice! > > All in all this looks really nice. > > Thanks for doing this. > Seconded, nice stuff! Thirded! ;-) Gave it a quick look, the ELF generation thing could later be librarized somehow for other uses, the passing of perf_session for sample_type can maybe use evsel->attr.sample_type instead, no? Will try to try it after lunch :-) - Arnaldo