From: Brian Norris <computersforpeace@gmail.com>
To: Kirill Smirnov <kirill.k.smirnov@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value
Date: Thu, 1 Oct 2015 10:08:49 -0700 [thread overview]
Message-ID: <20151001170849.GA12631@google.com> (raw)
In-Reply-To: <560C8A27.6060202@gmail.com>
On Thu, Oct 01, 2015 at 04:19:35AM +0300, Kirill Smirnov wrote:
> struct addrinfo and friends conform to POSIX.1-2001, not earlier.
> This patch fixes linking against latest glibc 2.22
>
> Now email formatting and the generated patch should be OK.
Normally we don't include lines like this ^^ in the commit message.
> Signed-off-by: Kirill Smirnov <kirill.k.smirnov@gmail.com>
> ---
But you can include comments like that (that don't belong in the commit
message) here, below the '---'.
Also, the extra attachment is not too much of a problem, but try to
avoid it in the future.
Anyway, patch looks reasonable to me. Applied to mtd-utils.git. Thanks!
Brian
> serve_image.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/serve_image.c b/serve_image.c
> index d3794ec..cbcf3b7 100644
> --- a/serve_image.c
> +++ b/serve_image.c
> @@ -1,5 +1,5 @@
> #define PROGRAM_NAME "serve_image"
> -#define _POSIX_C_SOURCE 199309
> +#define _POSIX_C_SOURCE 200112L
>
> #include <time.h>
> #include <errno.h>
> --
> 2.5.1
next prev parent reply other threads:[~2015-10-01 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 1:19 [PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value Kirill Smirnov
2015-10-01 17:08 ` Brian Norris [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-30 23:49 Kirill Smirnov
2015-10-01 1:04 ` Brian Norris
2015-10-01 1:25 ` Kirill Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001170849.GA12631@google.com \
--to=computersforpeace@gmail.com \
--cc=kirill.k.smirnov@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.