From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Date: Thu, 1 Oct 2015 21:17:45 +0200 Subject: [Intel-wired-lan] [PATCH 03/12] net: igb: avoid using timespec In-Reply-To: <1443612402-3000775-4-git-send-email-arnd@arndb.de> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> Message-ID: <20151001191745.GC1872@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Arnd As author of these snippets, I went ahead and reviewed. I have one comment, below. Reviewed-by: Richard Cochran On Wed, Sep 30, 2015 at 01:26:33PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c > index 5982f28d521a..c44df87c38de 100644 > --- a/drivers/net/ethernet/intel/igb/igb_ptp.c > +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c > @@ -143,7 +143,7 @@ static void igb_ptp_write_i210(struct igb_adapter *adapter, > * sub-nanosecond resolution. > */ > wr32(E1000_SYSTIML, ts->tv_nsec); > - wr32(E1000_SYSTIMH, ts->tv_sec); > + wr32(E1000_SYSTIMH, (u32)ts->tv_sec); This cast is unnecessary, because wr32 is writel, and that parameter is a u32. Thanks, Richard > } > > /** From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933193AbbJATRx (ORCPT ); Thu, 1 Oct 2015 15:17:53 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:35896 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932923AbbJATRu (ORCPT ); Thu, 1 Oct 2015 15:17:50 -0400 Date: Thu, 1 Oct 2015 21:17:45 +0200 From: Richard Cochran To: Arnd Bergmann Cc: netdev@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jeff Kirsher , intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH 03/12] net: igb: avoid using timespec Message-ID: <20151001191745.GC1872@localhost.localdomain> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443612402-3000775-4-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd As author of these snippets, I went ahead and reviewed. I have one comment, below. Reviewed-by: Richard Cochran On Wed, Sep 30, 2015 at 01:26:33PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c > index 5982f28d521a..c44df87c38de 100644 > --- a/drivers/net/ethernet/intel/igb/igb_ptp.c > +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c > @@ -143,7 +143,7 @@ static void igb_ptp_write_i210(struct igb_adapter *adapter, > * sub-nanosecond resolution. > */ > wr32(E1000_SYSTIML, ts->tv_nsec); > - wr32(E1000_SYSTIMH, ts->tv_sec); > + wr32(E1000_SYSTIMH, (u32)ts->tv_sec); This cast is unnecessary, because wr32 is writel, and that parameter is a u32. Thanks, Richard > } > > /** From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH 03/12] net: igb: avoid using timespec Date: Thu, 1 Oct 2015 21:17:45 +0200 Message-ID: <20151001191745.GC1872@localhost.localdomain> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: y2038@lists.linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jeff Kirsher , "David S. Miller" To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <1443612402-3000775-4-git-send-email-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" List-Id: netdev.vger.kernel.org QXJuZAoKQXMgYXV0aG9yIG9mIHRoZXNlIHNuaXBwZXRzLCBJIHdlbnQgYWhlYWQgYW5kIHJldmll d2VkLiAgSSBoYXZlIG9uZQpjb21tZW50LCBiZWxvdy4KClJldmlld2VkLWJ5OiBSaWNoYXJkIENv Y2hyYW4gPHJpY2hhcmRjb2NocmFuQGdtYWlsLmNvbT4KCk9uIFdlZCwgU2VwIDMwLCAyMDE1IGF0 IDAxOjI2OjMzUE0gKzAyMDAsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2lnYi9pZ2JfcHRwLmMgYi9kcml2ZXJzL25ldC9ldGhl cm5ldC9pbnRlbC9pZ2IvaWdiX3B0cC5jCj4gaW5kZXggNTk4MmYyOGQ1MjFhLi5jNDRkZjg3YzM4 ZGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaWdiL2lnYl9wdHAu Ywo+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2lnYi9pZ2JfcHRwLmMKPiBAQCAt MTQzLDcgKzE0Myw3IEBAIHN0YXRpYyB2b2lkIGlnYl9wdHBfd3JpdGVfaTIxMChzdHJ1Y3QgaWdi X2FkYXB0ZXIgKmFkYXB0ZXIsCj4gIAkgKiBzdWItbmFub3NlY29uZCByZXNvbHV0aW9uLgo+ICAJ ICovCj4gIAl3cjMyKEUxMDAwX1NZU1RJTUwsIHRzLT50dl9uc2VjKTsKPiAtCXdyMzIoRTEwMDBf U1lTVElNSCwgdHMtPnR2X3NlYyk7Cj4gKwl3cjMyKEUxMDAwX1NZU1RJTUgsICh1MzIpdHMtPnR2 X3NlYyk7CgpUaGlzIGNhc3QgaXMgdW5uZWNlc3NhcnksIGJlY2F1c2Ugd3IzMiBpcyB3cml0ZWws IGFuZCB0aGF0IHBhcmFtZXRlcgppcyBhIHUzMi4KClRoYW5rcywKUmljaGFyZAoKPiAgfQo+ICAK PiAgLyoqCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClky MDM4IG1haWxpbmcgbGlzdApZMjAzOEBsaXN0cy5saW5hcm8ub3JnCmh0dHBzOi8vbGlzdHMubGlu YXJvLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg==