All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: alex.aring@gmail.com
Cc: linux-wpan@vger.kernel.org
Subject: re: nl802154: add support for security layer
Date: Fri, 2 Oct 2015 01:17:55 +0300	[thread overview]
Message-ID: <20151001221755.GA13590@mwanda> (raw)

Hello Alexander Aring,

The patch a26c5fd7622d: "nl802154: add support for security layer"
from Sep 28, 2015, leads to the following static checker warning:

	net/ieee802154/nl802154.c:1535 nl802154_add_llsec_key()
	warn: if statement not indented

net/ieee802154/nl802154.c
  1530          if (nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX,
  1531                               info->attrs[NL802154_ATTR_SEC_KEY],
  1532                               nl802154_key_policy))
  1533                  return -EINVAL;
  1534  
  1535          if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
  1536              !attrs[NL802154_KEY_ATTR_BYTES])

Should this be a return -EINVAL?

  1537  
  1538          if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)
  1539                  return -ENOBUFS;
  1540  

regards,
dan carpenter

             reply	other threads:[~2015-10-01 22:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 22:17 Dan Carpenter [this message]
2015-10-02  7:20 ` nl802154: add support for security layer Alexander Aring
2015-10-02  7:47   ` [patch] nl802154: Missing return in nl802154_add_llsec_key() Dan Carpenter
2015-10-02  7:47     ` Dan Carpenter
2015-10-02 10:37     ` Alexander Aring
2015-10-02 10:37       ` Alexander Aring
2015-10-02 21:35     ` Marcel Holtmann
2015-10-02 21:35       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001221755.GA13590@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.