From: Stephen Boyd <sboyd@codeaurora.org>
To: Victorien Vedrine <victorien.vedrine@ophrys.net>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
mturquette@baylibre.com, shawn.guo@linaro.org
Subject: Re: [PATCH v2] clk:mxs: Fix bug on frequency divider
Date: Thu, 1 Oct 2015 15:25:10 -0700 [thread overview]
Message-ID: <20151001222510.GP19319@codeaurora.org> (raw)
In-Reply-To: <1441010707-17178-1-git-send-email-victorien.vedrine@ophrys.net>
On 08/31, Victorien Vedrine wrote:
> On drivers/clk/mxs/clk-frac.c, the function clk_frac_round_rate returned a bad
> result. The division before multiplication computes a wrong value ; the
> calculation is inverted to fix the problem. The second issue is that the exact
> rate have decimals and they are truncate. The consequence is that the function
> clk_frac_set_rate (which use the result of clk_frac_round_rate) computes a
> wrong value for the register (the rate generated can be closer to the desired
> rate). The correction is : if there is decimal to the result, it is rounded to
> the next larger integer.
> On drivers/clk/mxs/clk-frac.c, the function clk_frac_recalc_rate returned
> a bad result. The multiplication is made before the division to compute a
> correct value.
>
> Signed-off-by: Victorien Vedrine <victorien.vedrine@ophrys.net>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-10-01 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 16:24 [PATCH] clk:mxs: Fix bug on frequency divider Victorien Vedrine
2015-07-31 17:34 ` Stephen Boyd
2015-08-19 10:29 ` victorien.vedrine
2015-08-31 8:45 ` [PATCH v2] " Victorien Vedrine
2015-09-16 14:16 ` Stefan Wahren
2015-09-18 7:21 ` Stefan Wahren
2015-09-18 7:21 ` Stefan Wahren
2015-09-24 12:17 ` Shawn Guo
2015-09-24 12:17 ` Shawn Guo
2015-10-01 22:25 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001222510.GP19319@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawn.guo@linaro.org \
--cc=victorien.vedrine@ophrys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.