From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Fri, 02 Oct 2015 01:57:13 +0000 Subject: Re: [PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id Message-Id: <20151002015713.GA7043@verge.net.au> List-Id: References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-14-git-send-email-a.hajda@samsung.com> In-Reply-To: <1442842450-29769-14-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon, Sep 21, 2015 at 03:33:45PM +0200, Andrzej Hajda wrote: > CPU id can be negative, so it cannot be assigned to unsigned variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda Thanks, I have queued this up as a cleanup for v4.4. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Fri, 2 Oct 2015 10:57:13 +0900 Subject: [PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id In-Reply-To: <1442842450-29769-14-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-14-git-send-email-a.hajda@samsung.com> Message-ID: <20151002015713.GA7043@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 21, 2015 at 03:33:45PM +0200, Andrzej Hajda wrote: > CPU id can be negative, so it cannot be assigned to unsigned variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda Thanks, I have queued this up as a cleanup for v4.4. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbbJBB5P (ORCPT ); Thu, 1 Oct 2015 21:57:15 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:47115 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbJBB5N (ORCPT ); Thu, 1 Oct 2015 21:57:13 -0400 Date: Fri, 2 Oct 2015 10:57:13 +0900 From: Simon Horman To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-sh@vger.kernel.org, Magnus Damm , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Subject: Re: [PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id Message-ID: <20151002015713.GA7043@verge.net.au> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-14-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442842450-29769-14-git-send-email-a.hajda@samsung.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 03:33:45PM +0200, Andrzej Hajda wrote: > CPU id can be negative, so it cannot be assigned to unsigned variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda Thanks, I have queued this up as a cleanup for v4.4.