From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-input@vger.kernel.org
Subject: Re: Input: gamecon - use parallel port device model
Date: Fri, 2 Oct 2015 11:09:20 +0530 [thread overview]
Message-ID: <20151002053920.GD3544@sudip-pc> (raw)
In-Reply-To: <20151001220532.GA493@mwanda>
On Fri, Oct 02, 2015 at 01:05:32AM +0300, Dan Carpenter wrote:
> Hello Sudip Mukherjee,
>
> The patch a517e87c3dfc: "Input: gamecon - use parallel port device
> model" from Sep 29, 2015, leads to the following static checker
> warning:
>
> drivers/input/joystick/gamecon.c:988 gc_attach()
> error: buffer overflow 'gc_base' 3 <= 5
>
> drivers/input/joystick/gamecon.c
> 972
> 973 for (i = 0; i < n_pads && i < GC_MAX_DEVICES; i++) {
> ^^^^^^^^^^^^^^
Thanks Dan. This would have been an ugly mess. I checked my othher
patches and looks like they will also have the same mistake. I will send
the patch to fix this rightaway.
Thanks again.
regards
sudip
prev parent reply other threads:[~2015-10-02 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 22:05 Input: gamecon - use parallel port device model Dan Carpenter
2015-10-02 5:39 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002053920.GD3544@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.