From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: Rachel Kim <rachel.kim@atmel.com>,
devel@driverdev.osuosl.org, Chris Park <chris.park@atmel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Johnny Kim <johnny.kim@atmel.com>,
"tony.cho" <tony.cho@atmel.com>,
leo.kim@atmel.com
Subject: Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t
Date: Fri, 2 Oct 2015 09:06:22 +0300 [thread overview]
Message-ID: <20151002060622.GK7340@mwanda> (raw)
In-Reply-To: <CAKV=isutNb+AeLyZPO9x=h90FeQr8+JfTOFka0bY7SoWofwLbQ@mail.gmail.com>
On Fri, Oct 02, 2015 at 07:56:28AM +0900, Chaehyun Lim wrote:
> On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote:
> >> This patch replaces int8_t with s8 that is a preferred type.
> >>
> >
> > It would be better to just use int.
>
> I always appreciate your comment. I've sent a patch before after
> changing by int, but it was rejected.
Probably your changelog was bad. Using s8 is hopefully a sign that you
are doing something very hardware specific. In this case, it is just a
index.
Write the changelog. "The int8_t should just be int. It's used as an
index into an array or -1 for not found."
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-02 6:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 13:43 [PATCH 01/12] staging: wilc1000: remove wilc_platform.h Chaehyun Lim
2015-10-01 13:43 ` [PATCH 02/12] staging: wilc1000: remove commented codes Chaehyun Lim
2015-10-01 13:43 ` [PATCH 03/12] staging: wilc1000: remove if defined codes of USE_OLD_SPI_SW Chaehyun Lim
2015-10-01 13:43 ` [PATCH 04/12] staging: wilc1000: fix indentation level Chaehyun Lim
2015-10-01 13:43 ` [PATCH 05/12] staging: wilc1000: remove #if 1 and #endif Chaehyun Lim
2015-10-01 13:43 ` [PATCH 06/12] staging: wilc1000: remove unnecessary comment Chaehyun Lim
2015-10-01 13:43 ` [PATCH 07/12] staging: wilc1000: use ARRAY_SIZE macro Chaehyun Lim
2015-10-01 13:43 ` [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t Chaehyun Lim
2015-10-01 15:40 ` Dan Carpenter
2015-10-01 22:56 ` Chaehyun Lim
2015-10-02 6:06 ` Dan Carpenter [this message]
2015-10-02 7:02 ` Chaehyun Lim
2015-10-02 7:45 ` Arend van Spriel
2015-10-02 7:49 ` Arend van Spriel
2015-10-02 11:37 ` Dan Carpenter
2015-10-04 21:06 ` Arend van Spriel
2015-10-01 13:43 ` [PATCH 09/12] staging: wilc1000: set_channel: remove blank line after open brace Chaehyun Lim
2015-10-01 13:43 ` [PATCH 10/12] staging: wilc1000: set_channel: fix data type of s32Error Chaehyun Lim
2015-10-01 13:43 ` [PATCH 11/12] staging: wilc1000: set_channel: rename s32Error Chaehyun Lim
2015-10-01 13:43 ` [PATCH 12/12] staging: wilc1000: rename u8CurrChannel Chaehyun Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002060622.GK7340@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.