From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbbJBHIr (ORCPT ); Fri, 2 Oct 2015 03:08:47 -0400 Received: from bes.se.axis.com ([195.60.68.10]:43118 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbbJBHIp (ORCPT ); Fri, 2 Oct 2015 03:08:45 -0400 Date: Fri, 2 Oct 2015 09:08:41 +0200 From: Jesper Nilsson To: Valentin Rothberg Cc: rabin@rab.in, jespern@axis.com, Paul Bolle , ziegler@cs.fau.de, linux-kernel@vger.kernel.org Subject: Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO Message-ID: <20151002070841.GP4919@axis.com> References: <20151002065722.GA1804@nebuchadnezzar.informatik.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151002065722.GA1804@nebuchadnezzar.informatik.uni-erlangen.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2015 at 08:57:22AM +0200, Valentin Rothberg wrote: > Hi Rabin, Hi! > your commit ("CRIS v32: remove old GPIO and LEDs code") is in today's > linux-next tree (i.e., 20151002). Among other Kconfig options, the > commit removes ETRAX_VIRTUAL_GPIO but leaves the following references in > the code: > > 0 arch/cris/arch-v32/kernel/setup.c 132 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO > 1 arch/cris/arch-v32/kernel/setup.c 149 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO > 2 arch/cris/arch-v32/mach-fs/Kconfig 197 depends on ETRAX_VIRTUAL_GPIO > 3 arch/cris/arch-v32/mach-fs/Kconfig 208 depends on ETRAX_VIRTUAL_GPIO > 4 arch/cris/include/uapi/asm/etraxgpio.h 59 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO > 5 arch/cris/include/uapi/asm/etraxgpio.h 74 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO > > Is it intentional or just an accident? I'm guessing it's an accident, I did have some trouble applying that particular patch and I had to verify the patch by hand, but I might have made a mistake and removed something that Rabin didn't remove. (Since I knew this symbol was tightly connected to the CRIS gpio) Anyways, I'll roll a patch for removing them, thanks for the heads-up! /Jesper > I found the issue with scripts/checkkconfigsymbols.py. > > Kind regards, > Valentin /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com