From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Date: Fri, 2 Oct 2015 09:47:16 +0200 Subject: [Intel-wired-lan] [PATCH 03/12] net: igb: avoid using timespec In-Reply-To: <1803983.ImzkvzgWES@wuerfel> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> <20151001191745.GC1872@localhost.localdomain> <1803983.ImzkvzgWES@wuerfel> Message-ID: <20151002074716.GA3930@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote: > I tried to use this pattern whenever I convert the 64-bit 'long long' > tv_sec member of 'struct timespec64' into a 32-bit number, to annotate > the loss of range. Sounds reasonable to me. > I have thought about defining separate helpers like this ... > This would make it even more explicit, but my fear was that I was > adding too much complexity like that. I think a cast plus a comment when needed is clear enough. Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbbJBHr1 (ORCPT ); Fri, 2 Oct 2015 03:47:27 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35236 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbJBHrY (ORCPT ); Fri, 2 Oct 2015 03:47:24 -0400 Date: Fri, 2 Oct 2015 09:47:16 +0200 From: Richard Cochran To: Arnd Bergmann Cc: netdev@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jeff Kirsher , intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH 03/12] net: igb: avoid using timespec Message-ID: <20151002074716.GA3930@localhost.localdomain> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> <20151001191745.GC1872@localhost.localdomain> <1803983.ImzkvzgWES@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1803983.ImzkvzgWES@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote: > I tried to use this pattern whenever I convert the 64-bit 'long long' > tv_sec member of 'struct timespec64' into a 32-bit number, to annotate > the loss of range. Sounds reasonable to me. > I have thought about defining separate helpers like this ... > This would make it even more explicit, but my fear was that I was > adding too much complexity like that. I think a cast plus a comment when needed is clear enough. Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH 03/12] net: igb: avoid using timespec Date: Fri, 2 Oct 2015 09:47:16 +0200 Message-ID: <20151002074716.GA3930@localhost.localdomain> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-4-git-send-email-arnd@arndb.de> <20151001191745.GC1872@localhost.localdomain> <1803983.ImzkvzgWES@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: y2038@lists.linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jeff Kirsher , "David S. Miller" To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <1803983.ImzkvzgWES@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" List-Id: netdev.vger.kernel.org T24gVGh1LCBPY3QgMDEsIDIwMTUgYXQgMTA6MDE6NTdQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBJIHRyaWVkIHRvIHVzZSB0aGlzIHBhdHRlcm4gd2hlbmV2ZXIgSSBjb252ZXJ0IHRo ZSA2NC1iaXQgJ2xvbmcgbG9uZycKPiB0dl9zZWMgbWVtYmVyIG9mICdzdHJ1Y3QgdGltZXNwZWM2 NCcgaW50byBhIDMyLWJpdCBudW1iZXIsIHRvIGFubm90YXRlCj4gdGhlIGxvc3Mgb2YgcmFuZ2Uu CgpTb3VuZHMgcmVhc29uYWJsZSB0byBtZS4KIAo+IEkgaGF2ZSB0aG91Z2h0IGFib3V0IGRlZmlu aW5nIHNlcGFyYXRlIGhlbHBlcnMgbGlrZSB0aGlzCi4uLgo+IFRoaXMgd291bGQgbWFrZSBpdCBl dmVuIG1vcmUgZXhwbGljaXQsIGJ1dCBteSBmZWFyIHdhcyB0aGF0IEkgd2FzCj4gYWRkaW5nIHRv byBtdWNoIGNvbXBsZXhpdHkgbGlrZSB0aGF0LgoKSSB0aGluayBhIGNhc3QgcGx1cyBhIGNvbW1l bnQgd2hlbiBuZWVkZWQgaXMgY2xlYXIgZW5vdWdoLgoKVGhhbmtzLApSaWNoYXJkCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClkyMDM4IG1haWxpbmcgbGlz dApZMjAzOEBsaXN0cy5saW5hcm8ub3JnCmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9tYWlsbWFu L2xpc3RpbmZvL3kyMDM4Cg==