From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3] staging: wlan-ng: replace memcpy with ether_addr_copy
Date: Fri, 2 Oct 2015 16:04:58 +0530 [thread overview]
Message-ID: <20151002103458.GE9346@sudip-pc> (raw)
In-Reply-To: <1443779964-12035-1-git-send-email-ciorneiioana@gmail.com>
On Fri, Oct 02, 2015 at 12:59:24PM +0300, Ioana Ciornei wrote:
> Replace memcpy with ether_addr_copy since the output of pahole
> shows that the addresses are aligned.
Please always check your patch using checkpatch before sending. And more
important than that your patch is introducing build warnings.
checkpatch errors:
ERROR: "(foo*)" should be "(foo *)"
Build warnings:
drivers/staging/wlan-ng/p80211netdev.c: In function ‘p80211knetdev_set_mac_address’:
drivers/staging/wlan-ng/p80211netdev.c:647:2: warning: passing argument 1 of ‘ether_addr_copy’ from incompatible pointer type [enabled by default]
ether_addr_copy(&macaddr->data.data, new_addr->sa_data);
^
In file included from drivers/staging/wlan-ng/p80211netdev.c:65:0:
include/linux/etherdevice.h:271:20: note: expected ‘u8 *’ but argument is of type ‘u8 (*)[6]’
static inline void ether_addr_copy(u8 *dst, const u8 *src)
^
regards
sudip
next prev parent reply other threads:[~2015-10-02 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 9:59 [PATCH v3] staging: wlan-ng: replace memcpy with ether_addr_copy Ioana Ciornei
2015-10-02 10:34 ` Sudip Mukherjee [this message]
2015-10-02 10:53 ` [Outreachy kernel] " Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002103458.GE9346@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=ciorneiioana@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.