From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI: Fix hard lockup in scsi_remove_target()
Date: Fri, 2 Oct 2015 06:16:17 -0700 [thread overview]
Message-ID: <20151002131617.GA13860@infradead.org> (raw)
In-Reply-To: <mqdoagh5sdu.fsf@c203.arch.suse.de>
On Fri, Oct 02, 2015 at 03:09:33PM +0200, Johannes Thumshirn wrote:
> Having the list_move() outside of the host_lock was purely by
> accident. Interestingly the stressing didn't mind it. But yes you're
> right, __scsi_remove_target() should be made host_lock() save for being
> called under the host_lock.
>
> Regarding the list move, does it look OK for you (i.e. do we still need
> it after reworking __scsi_remove_target())? IMHO yes, but I only have
> half a year of experience in this area).
Hi Johannes,
your general approach looks fine, we just need to fix up the locking as
far as I can tell.
prev parent reply other threads:[~2015-10-02 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 8:21 [PATCH] SCSI: Fix hard lockup in scsi_remove_target() Johannes Thumshirn
2015-10-02 8:25 ` Hannes Reinecke
2015-10-02 12:49 ` Christoph Hellwig
2015-10-02 13:09 ` Johannes Thumshirn
2015-10-02 13:09 ` Johannes Thumshirn
2015-10-02 13:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002131617.GA13860@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.