From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Date: Fri, 2 Oct 2015 15:16:43 +0200 Message-ID: <20151002131643.GD10444@piout.net> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-2-git-send-email-sudeep.holla@arm.com> <560E603E.8080603@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: <560E603E.8080603@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Sudeep Holla Cc: Linus Walleij , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "Rafael J. Wysocki" , Alessandro Zummo , "rtc-linux@googlegroups.com" List-Id: linux-pm@vger.kernel.org On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote : > > > On 02/10/15 11:40, Linus Walleij wrote: > >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow them to work as expected during the > >>suspend-resume cycle, but doesn't guarantee that it will wake the system > >>from a suspended state, enable_irq_wake is recommended to be used for > >>the wakeup. > >> > >>This patch removes the use of IRQF_NO_SUSPEND flags and uses newly > >>introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. > >> > >>Cc: Linus Walleij > >>Cc: Alessandro Zummo > >>Cc: Alexandre Belloni > >>Cc: rtc-linux@googlegroups.com > >>Signed-off-by: Sudeep Holla > > > >Looks correct to me. > >Acked-by: Linus Walleij > > > > Thanks, while you are at it, do you know what interrupt stv2_pl031 > shares so that I can fix the TODO in the comment or the code(whichever > applicable). > So that you know, I'm planning to apply them this weekend, I couldn't find time to do it before. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id c1si230629wiv.3.2015.10.02.06.16.54 for ; Fri, 02 Oct 2015 06:16:54 -0700 (PDT) Date: Fri, 2 Oct 2015 15:16:43 +0200 From: Alexandre Belloni To: Sudeep Holla Cc: Linus Walleij , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "Rafael J. Wysocki" , Alessandro Zummo , "rtc-linux@googlegroups.com" Subject: [rtc-linux] Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Message-ID: <20151002131643.GD10444@piout.net> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-2-git-send-email-sudeep.holla@arm.com> <560E603E.8080603@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <560E603E.8080603@arm.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote : > > > On 02/10/15 11:40, Linus Walleij wrote: > >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow them to work as expected during the > >>suspend-resume cycle, but doesn't guarantee that it will wake the system > >>from a suspended state, enable_irq_wake is recommended to be used for > >>the wakeup. > >> > >>This patch removes the use of IRQF_NO_SUSPEND flags and uses newly > >>introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. > >> > >>Cc: Linus Walleij > >>Cc: Alessandro Zummo > >>Cc: Alexandre Belloni > >>Cc: rtc-linux@googlegroups.com > >>Signed-off-by: Sudeep Holla > > > >Looks correct to me. > >Acked-by: Linus Walleij > > > > Thanks, while you are at it, do you know what interrupt stv2_pl031 > shares so that I can fix the TODO in the comment or the code(whichever > applicable). > So that you know, I'm planning to apply them this weekend, I couldn't find time to do it before. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.