From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbJBRaY (ORCPT ); Fri, 2 Oct 2015 13:30:24 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:50845 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbbJBRaV (ORCPT ); Fri, 2 Oct 2015 13:30:21 -0400 Date: Fri, 2 Oct 2015 12:30:16 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 03/14] RFC: usb/host/fotg210: Remove useless else statement Message-ID: <20151002173016.GN5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-4-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GEn4szYucjS2InE7" Content-Disposition: inline In-Reply-To: <1442847678-7970-4-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GEn4szYucjS2InE7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:07PM +0200, Peter Senna Tschudin wrote: > This patch remove an else statement after a return to make the code > easier to understand. >=20 > Signed-off-by: Peter Senna Tschudin looks good to me. > --- > drivers/usb/host/fotg210-hcd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index 36413b2..f574143 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -1410,10 +1410,9 @@ static int check_reset_complete(struct fotg210_hcd= *fotg210, int index, > "Failed to enable port %d on root hub TT\n", > index+1); > return port_status; > - } else { > - fotg210_dbg(fotg210, "port %d reset complete, port enabled\n", > - index + 1); > } > + fotg210_dbg(fotg210, "port %d reset complete, port enabled\n", > + index + 1); > =20 > return port_status; > } > --=20 > 2.1.0 >=20 --=20 balbi --GEn4szYucjS2InE7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr8oAAoJEIaOsuA1yqREFTkP/3DcbAjhtRSj+RJ/KywJgX7m 98KO4AkYQl4Q0fq295wgg6zp8T0ejS/nkBxiKDV4sOVLhGwrQ6wGEywy8HF7QIRi 6tPJq7jLa1Qu0RGMFPZRt5EwCiHgQuP48C9hnVUVsYm5YvUofzO9TylQ7lpSd/f3 qq4XLsZFWBjn6kLo0rRsnGFk/jdY5VuCXKABYfjwVhCTE71xTIkyf/q0E5GhgVUt ggs35ewYFnLh0S4nPMAPNDtzWjobtEBQML3N9r6QQx8Apd3IAlEDfyLVeXCiFhTR KUsfeTDH9c9maYCVItpQ6vfU9pQQdAQhbmM1Moq1V/UHTE/yonXtWWmgcd36/QHP 8s2lVkFGpj1c/lj/NsL383sIrjVS5zc7OE8SfnQsejTCTweKlDKvWOB3TdPtSo7o aRhZ1Rqx6aNNm/tQwWI/34xRULXK9hakEzipK8JwmkNTZQWC6uJPTxPHOfrX9tKS Q2gILHX17XnVDyAzlFzUpPzuhpXvNmjt8sf29qcsw4U7KDeucPubiZJDSKFQEFzp 2mvwVNwD1qVhbp4PXh3GPvK5E3KbisF6rbl1LcsyWRil0gpaPCgPoe6xWYlMSgKn ANnp9QRd6A8DrS/OHPashS6Riip/mq3aZsfBpgcPYXzeWwLFScQQ8Lc1aFzaK6PU cY2DmrrLNH/Q5hubJX/7 =wWAj -----END PGP SIGNATURE----- --GEn4szYucjS2InE7--