From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbbJBRbA (ORCPT ); Fri, 2 Oct 2015 13:31:00 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37229 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbbJBRa5 (ORCPT ); Fri, 2 Oct 2015 13:30:57 -0400 Date: Fri, 2 Oct 2015 12:30:52 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 05/14] RFC: usb/host/fotg210: change kmalloc by kmalloc_array Message-ID: <20151002173052.GP5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-6-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NDuspjMMC1Ui5ypn" Content-Disposition: inline In-Reply-To: <1442847678-7970-6-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NDuspjMMC1Ui5ypn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:09PM +0200, Peter Senna Tschudin wrote: > This patch change: >=20 > kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC) >=20 > by: >=20 > kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC) >=20 > as kmalloc_array() should be used for allocating arrays. >=20 > Signed-off-by: Peter Senna Tschudin looks good to me > --- > drivers/usb/host/fotg210-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index 51feb61..e7e9991 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -501,7 +501,7 @@ static ssize_t fill_periodic_buffer(struct debug_buff= er *buf) > unsigned i; > __hc32 tag; > =20 > - seen =3D kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC); > + seen =3D kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC); > if (!seen) > return 0; > =20 > --=20 > 2.1.0 >=20 --=20 balbi --NDuspjMMC1Ui5ypn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr9MAAoJEIaOsuA1yqREihUP/A6Crn1RqgCDrwmJbGkykb8A oK7HPYQDCVkGxqehXmxn2EPQ19YjXVa8pROZVpLiKCg8OHhxiA8XKy2SGOFTpgn7 xEw6tNNQy5CYUouvlsYzCZeNOaSfrgkRbGJdDyMh1Iy8zbZ1i9gf3WaBtayb07QW Zy0b6exdSF+4PI2JKiP5NVC9oM6a5DhxFfUbr/o0U/RUkESObvkNiWhOXSxGmhBl CvO/V3D0Fy8e/eNxgom7AMb+YImbBQBdD87b47SUTBUgH9UYsyLaWzEqEdoy8OEv G8NyFUFDlp0grWDxetxqNZuouVXhwSx3rpQ4W6vz/PWVg09utVcAtFYRL7GW6cGN mpICaQzwPgdeSpI9F+9EW+N+FUaXKu4twSE7F6jUJEKQLuixVGpshNSqjUJfx7ED +oDSqZ5b9t03LkI437dc+X6xLHhK8qLMgL2KiI6oFOUDjchaXp7KCX01DCpf/BA5 fGU+L0scrTaWSgp/yyz5P+oSVjb8mN7uWrxB7XtY02UDyVebyCsr1ve/Pqt7x3Wf NrCKOD6F60XcUzN0j0zfw5Fq3ag3Nv1vz3kjtEyxCxumzfjOKrch/hjVd9RgfUoG 3RzVsbD8coMEnt3hW35+kK7/tl92XZG9GEuetogqBCY8DNqPXo2jr+zmIuMui11E A0YsAtf7RHQ2Vcmv5Fkh =JkXi -----END PGP SIGNATURE----- --NDuspjMMC1Ui5ypn--