From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753609AbbJBRbU (ORCPT ); Fri, 2 Oct 2015 13:31:20 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37246 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbbJBRbS (ORCPT ); Fri, 2 Oct 2015 13:31:18 -0400 Date: Fri, 2 Oct 2015 12:31:13 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range Message-ID: <20151002173113.GQ5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-7-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oN4OvwWIcd1E23D1" Content-Disposition: inline In-Reply-To: <1442847678-7970-7-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oN4OvwWIcd1E23D1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:10PM +0200, Peter Senna Tschudin wrote: > msleep under 20ms can result in sleeping up to 20ms, which may not be > intended. Replace msleep(5) by usleep_range(5000, 6000). >=20 > Signed-off-by: Peter Senna Tschudin good catch. I'd apply this straight away. Alan ? > --- > drivers/usb/host/fotg210-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index e7e9991..55c2279 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -5122,7 +5122,7 @@ static int fotg210_run(struct usb_hcd *hcd) > fotg210->rh_state =3D FOTG210_RH_RUNNING; > /* unblock posted writes */ > fotg210_readl(fotg210, &fotg210->regs->command); > - msleep(5); > + usleep_range(5000, 6000); > up_write(&ehci_cf_port_reset_rwsem); > fotg210->last_periodic_enable =3D ktime_get_real(); > =20 > --=20 > 2.1.0 >=20 --=20 balbi --oN4OvwWIcd1E23D1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr9hAAoJEIaOsuA1yqREvs4QAJquxmXMZULJ/rMWPJNqx926 ezTDKjrAjRjEaR+gWzSyGq87j22p0UGebK/wmGbvVTO4cL1rwjahu2znQz7WrOHQ fojY6Hva2h+hj5MeaTqt3WYvpIHCRWFL9UQF39e9SfG+tdIyTAyOIdCdGRcF4MOz bg32rm0nJeyfVSP4e6J0yuG4ZkYh3oxQghatFk1+qZgB7M0ARuC0RTceDEBCCwdi Ukc6Y0lZOCbukqptZ/sIGOq+LaNz+AfKGSmp+FXENfuQ6CBRQszajXc8SxmGkdXa hL6u9vN0M7oHUb/R0a+WCuCoNtIj9SKAd6cOsFVacwcNQ9mDCrUhW4G8RxBoZgib jTMkazTKlbwIXjrMe1+1IzZNzkd1D3nM2oNQy9IKIcVOQekJUqwbklIyjhUCiara VmDGPAxRBa+0KBzZp+nmZMXoAzkAPY4RoNZ3tFOGAc5ieEU0z6NlnmQ8uSMSbm6g ZP2QwCBE+Mt64gfqctPc5hG4WSBBghd4+QQp6AuZ85UDivR3ojXOUcLZzyCELTd5 aUkkwfXlE0qK5z0ULd6BJ9lsRhZCtgfKbMnTtCnSAbvdTeSlRSb1V0VXVFRL0gm9 xQvlmiMhKZwPD7b/a37Hofy2/Jb5VWCrdc01UDmlN2JLc/BrmvdiHbYGYZO/sQTL cCOoS2hdWWQRDeE9k9r+ =xoe+ -----END PGP SIGNATURE----- --oN4OvwWIcd1E23D1--