From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736AbbJBRbu (ORCPT ); Fri, 2 Oct 2015 13:31:50 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37263 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbbJBRbs (ORCPT ); Fri, 2 Oct 2015 13:31:48 -0400 Date: Fri, 2 Oct 2015 12:31:43 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 07/14] RFC: usb/host/fotg210: Remove a macro from snprintf Message-ID: <20151002173143.GR5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-8-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="magLDk5D4XGaUXcd" Content-Disposition: inline In-Reply-To: <1442847678-7970-8-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --magLDk5D4XGaUXcd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:11PM +0200, Peter Senna Tschudin wrote: > This patch removes a macro from a call to snprintf() and moves it's > content to just before the call to snprintf() assigning a value to a new > variable named tmp. The goal of this patch is to make the code easier to > understand. >=20 > Signed-off-by: Peter Senna Tschudin it's a little unnecessary, but no objections. > --- > drivers/usb/host/fotg210-hcd.c | 43 ++++++++++++++++++++++--------------= ------ > 1 file changed, 23 insertions(+), 20 deletions(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index 55c2279..4032ed0 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -367,6 +367,8 @@ static void qh_lines(struct fotg210_hcd *fotg210, str= uct fotg210_qh *qh, > unsigned size =3D *sizep; > char *next =3D *nextp; > char mark; > + char *tmp; > + > __le32 list_end =3D FOTG210_LIST_END(fotg210); > struct fotg210_qh_hw *hw =3D qh->hw; > =20 > @@ -411,28 +413,29 @@ static void qh_lines(struct fotg210_hcd *fotg210, s= truct fotg210_qh *qh, > else if (td->hw_alt_next !=3D list_end) > mark =3D '/'; > } > - temp =3D snprintf(next, size, > - "\n\t%p%c%s len=3D%d %08x urb %p", > - td, mark, ({ char *tmp; > - switch ((scratch>>8)&0x03) { > - case 0: > - tmp =3D "out"; > - break; > - case 1: > - tmp =3D "in"; > - break; > - case 2: > - tmp =3D "setup"; > - break; > - default: > - tmp =3D "?"; > - break; > - } tmp; }), > - (scratch >> 16) & 0x7fff, > - scratch, > - td->urb); > + > + switch ((scratch >> 8) & 0x03) { > + case 0: > + tmp =3D "out"; > + break; > + case 1: > + tmp =3D "in"; > + break; > + case 2: > + tmp =3D "setup"; > + break; > + default: > + tmp =3D "?"; > + break; > + } > + > + temp =3D snprintf(next, size, "\n\t%p%c%s len=3D%d %08x urb %p", > + td, mark, tmp, (scratch >> 16) & 0x7fff, > + scratch, td->urb); > + > if (size < temp) > temp =3D size; > + > size -=3D temp; > next +=3D temp; > if (temp =3D=3D size) > --=20 > 2.1.0 >=20 --=20 balbi --magLDk5D4XGaUXcd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr9/AAoJEIaOsuA1yqREnwsQAI2DyrmZNf4QPxOeO2A3FOw0 zU3UeeJ/4FTcKBR9BmkAAJ8g2CFGbNhoXqN+VNzDpB+8oFeZzW+zIeKwahSnC1e4 bbe8OjczLqTowQvo2gEzUKnGOkdDEy75dAwmabvaYpwc6QUuIYiBItwFuCJmA/aZ 44Ly1BN0r3gzjugbwobSCve6ucE8iUiIRZzGZFRQqwfCeiv+oRlx/zziTDfRsg36 ssv5a3ah0YIFDsfpQAitW5fLrNxzqvo2bFYB0pitj1DHMYdg0gb/bfIHs4MgrgiQ oFJcydpv70TR4BYq1JSEppLlSjhu272mdIwm3jueQde236JB2KHQoF3VvG7e5Ek2 LDe8jHK6a6+cSUVVEIcmSSEezu6r8br0SDZUL+j6h64lUNxlrIM3NwXHAdjMn/Qf dnxzlYHMnQ9jcS1IJKfBuZ79Aysvco/aI86/OyOR6luzPtBar+8bdwdoN+ORpplN pHbuj3URYExIzye6bcC59Y3Pcbyvq97WiHL987CEll8dFOnzlz59BTTM5zjPzIMc XDXFfamyOBHu3A4e/nREcffMauaUi3M629TLi3c3jurDjk/a7mKLRuWiwMunCHJq Hna4npTsajlP7qLXJUhpsUOadhNHvq1XXKcHZYZp/Qzd6VSWWnOBqZBj+3DG1bS9 ac236W3wvdnK/2l+LaLc =3Rqn -----END PGP SIGNATURE----- --magLDk5D4XGaUXcd--