From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbbJBRcI (ORCPT ); Fri, 2 Oct 2015 13:32:08 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:50907 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbbJBRcG (ORCPT ); Fri, 2 Oct 2015 13:32:06 -0400 Date: Fri, 2 Oct 2015 12:32:01 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 08/14] RFC: usb/host/fotg210: convert macro to inline function Message-ID: <20151002173201.GS5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-9-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uNvczuo8OWfsyO2w" Content-Disposition: inline In-Reply-To: <1442847678-7970-9-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uNvczuo8OWfsyO2w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:12PM +0200, Peter Senna Tschudin wrote: > This patch convert the macro speed_char in an inline function. The goal > of this patch is to make the code easier to read. >=20 > Signed-off-by: Peter Senna Tschudin looks good > --- > drivers/usb/host/fotg210-hcd.c | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index 4032ed0..82cd5da 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -331,17 +331,22 @@ struct debug_buffer { > size_t alloc_size; > }; > =20 > -#define speed_char(info1)({ char tmp; \ > - switch (info1 & (3 << 12)) { \ > - case QH_FULL_SPEED: \ > - tmp =3D 'f'; break; \ > - case QH_LOW_SPEED: \ > - tmp =3D 'l'; break; \ > - case QH_HIGH_SPEED: \ > - tmp =3D 'h'; break; \ > - default: \ > - tmp =3D '?'; break; \ > - } tmp; }) > +static inline char speed_char(u32 scratch) > +{ > + switch (scratch & (3 << 12)) { > + case QH_FULL_SPEED: > + return 'f'; > + > + case QH_LOW_SPEED: > + return 'l'; > + > + case QH_HIGH_SPEED: > + return 'h'; > + > + default: > + return '?'; > + } > +} > =20 > static inline char token_mark(struct fotg210_hcd *fotg210, __hc32 token) > { > --=20 > 2.1.0 >=20 --=20 balbi --uNvczuo8OWfsyO2w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr+RAAoJEIaOsuA1yqREEn4P/3YMWwYpwMlgt0Egxj/M8iVo rml0Xb/R7D1XnETwm/1b6cjbGed6p06vkOUHM0soO6Q11G2VDk8xPr0Q+Ww8gb0b NlE/OCrQPBOanyavyhhorcEBxJ2SoF4W3Vhud4NsiWFfNS9Uhlhnd3rbKWQwYkBS 2lveeZIFMT4TkqONuyyKNoD4+zje3rFrywoFTgD94rHU2myNg/QhtoWGWqmUkB0G Nz2XWoGwSL5WjEoRD8024pL+a90m65+4u/6FsGW+E/ljhSPHafiUuybznuKw1NIX NC/QAp3oZrF7B2a9S/9x5Y/7WgGtHVUcZPnL6xB7W0dJTD9YsY2qjpCN2TYVBIvi KgOVirUnafdtLeh7ui02rnUTYlwzfXKdw4YQKffmIiGPCl+WhIwnxYhz14Fl5tyA d0shqxx2jkMXYUoCtN9S/5yEwCBWWvgHylzuCy3yH8hEG/6yCuCnS80TQ1jMl7Op CdwOL1dGfdX/WZnUyx+zB8H4YyJX+GoGrtRttq51YVz2iFI++PXxlzFgoBDpjBQj PYOy2DT4X+JbiGWbwCcJ8t7d43DGbtPqbXXgukiiyhqC2oNpH1y8quuMLI2/MSww CdbBDW4WnuW6nQw0U1T5Ra6Cg1Y++66P9L+V9JYeG9jJqfQNJ3cDRx4w3K1euRHH z6+fW3MPsT0uAeQALl8r =4Tcm -----END PGP SIGNATURE----- --uNvczuo8OWfsyO2w--