Re: [Qemu-devel] [PATCH] ppc: drop useless register sync

[Greg Kurz <gkurz@linux.vnet.ibm.com>]

On Fri, 2 Oct 2015 16:03:56 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 01/10/15 18:56, Greg Kurz wrote:
> > Since msr is always synced, no need to read it from KVM.
> 
> Out of curiosity: Where does that happen?
> 

It does not happen in fact... and this patch indeed breaks LE guests...

Not really sure how I got there... just forget it ! :)

Cheers.

--
Greg

> Thanks,
>  Thomas
> 
> 
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > ---
> >  target-ppc/translate_init.c |    2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> > index b54147350d88..49611e8e41fe 100644
> > --- a/target-ppc/translate_init.c
> > +++ b/target-ppc/translate_init.c
> > @@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
> >      PowerPCCPU *cpu = POWERPC_CPU(cs);
> >      CPUPPCState *env = &cpu->env;
> >  
> > -    cpu_synchronize_state(cs);
> > -
> >      return !msr_le;
> >  }
> >  #endif
> > 
> > 
>