From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Linux Input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] input: gpio_keys: Don't report events on gpio failure
Date: Fri, 2 Oct 2015 10:44:33 -0700 [thread overview]
Message-ID: <20151002174433.GD8437@dtor-ws> (raw)
In-Reply-To: <CACRpkdaCFgNpHcK9q_rbA5igE3vAnQJeAOkYB0c+a_Grwy2NUA@mail.gmail.com>
On Fri, Oct 02, 2015 at 03:34:45AM -0700, Linus Walleij wrote:
> On Mon, Jul 27, 2015 at 6:50 PM, Bjorn Andersson
> <bjorn.andersson@sonymobile.com> wrote:
>
> > In the cases where the gpio chip fails to acquire the current state an
> > error is reported back to gpio_keys. This is currently interpreted as if
> > the line went high, which just confuses the developer.
> >
> > This patch introduces an error print in this case and skipps the
> > reporting of a input event; to aid in debugging this issue.
> >
> > Reported-by: John Stultz <john.stultz@linaro.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2015-10-02 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 1:50 [PATCH] input: gpio_keys: Don't report events on gpio failure Bjorn Andersson
2015-07-28 1:50 ` Bjorn Andersson
2015-07-28 21:00 ` Dmitry Torokhov
2015-08-10 22:41 ` Bjorn Andersson
2015-08-10 22:41 ` Bjorn Andersson
2015-08-13 13:06 ` Linus Walleij
2015-08-17 6:59 ` Alexandre Courbot
2015-08-17 19:34 ` Bjorn Andersson
2015-08-31 4:51 ` Alexandre Courbot
2015-08-26 7:34 ` Linus Walleij
2015-09-21 4:19 ` Bjorn Andersson
2015-10-02 10:34 ` Linus Walleij
2015-10-02 17:44 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002174433.GD8437@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=john.stultz@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.