All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Stefan Roese <sr@denx.de>
Cc: linux-mtd@lists.infradead.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 3/3 v2] mtd: nand: fsmc: Add BCH4 SW ECC support for SPEAr600
Date: Fri, 2 Oct 2015 11:04:02 -0700	[thread overview]
Message-ID: <20151002180402.GI107187@google.com> (raw)
In-Reply-To: <1443782422-4515-3-git-send-email-sr@denx.de>

Please base your series on linux-next.git or l2-mtd.git. See:

http://linux-mtd.infradead.org/source.html

or the MAINTAINERS file.

On Fri, Oct 02, 2015 at 12:40:22PM +0200, Stefan Roese wrote:
> --- a/drivers/mtd/nand/fsmc_nand.c
> +++ b/drivers/mtd/nand/fsmc_nand.c
> @@ -1023,12 +1023,17 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
>  	nand->cmd_ctrl = fsmc_cmd_ctrl;
>  	nand->chip_delay = 30;
>  
> +	/*
> +	 * Setup default ECC mode. nand_dt_init() called from nand_scan_init()
> +	 * can overwrite this value if the DT provides a different value.
> +	 */
>  	nand->ecc.mode = NAND_ECC_HW;
>  	nand->ecc.hwctl = fsmc_enable_hwecc;
>  	nand->ecc.size = 512;
>  	nand->options = pdata->options;
>  	nand->select_chip = fsmc_select_chip;
>  	nand->badblockbits = 7;
> +	nand->dn = np;

drivers/mtd/nand/fsmc_nand.c: In function ‘fsmc_nand_probe’:
drivers/mtd/nand/fsmc_nand.c:1036:6: error: ‘struct nand_chip’ has no member named ‘dn’

This field was renamed for clarity, to flash_node.

>  
>  	if (pdata->width == FSMC_NAND_BW16)
>  		nand->options |= NAND_BUSWIDTH_16;

[...]

Brian

  reply	other threads:[~2015-10-02 18:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 10:40 [PATCH 1/3] mtd: nand: fsmc: Small whitespace cleanup Stefan Roese
2015-10-02 10:40 ` [PATCH 2/3] mtd: nand: fsmc: Remove BUG macros Stefan Roese
2015-10-05  7:42   ` Linus Walleij
2015-10-02 10:40 ` [PATCH 3/3 v2] mtd: nand: fsmc: Add BCH4 SW ECC support for SPEAr600 Stefan Roese
2015-10-02 18:04   ` Brian Norris [this message]
2015-10-19  6:40   ` [PATCH 3/3 v3] " Stefan Roese
2015-10-26 20:20     ` Brian Norris
2015-10-27  5:49       ` Stefan Roese
2015-10-02 18:09 ` [PATCH 1/3] mtd: nand: fsmc: Small whitespace cleanup Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002180402.GI107187@google.com \
    --to=computersforpeace@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sr@denx.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.