From: Stephen Boyd <sboyd@codeaurora.org>
To: Suman Anna <s-anna@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Mike Turquette <mturquette@baylibre.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: dflt: fix enable_reg validity check
Date: Fri, 2 Oct 2015 11:21:33 -0700 [thread overview]
Message-ID: <20151002182133.GO12338@codeaurora.org> (raw)
In-Reply-To: <1443566267-50225-1-git-send-email-s-anna@ti.com>
On 09/29, Suman Anna wrote:
> diff --git a/drivers/clk/ti/clkt_dflt.c b/drivers/clk/ti/clkt_dflt.c
> index 90d7d8a21c49..1ddc288fce4e 100644
> --- a/drivers/clk/ti/clkt_dflt.c
> +++ b/drivers/clk/ti/clkt_dflt.c
> @@ -222,7 +222,7 @@ int omap2_dflt_clk_enable(struct clk_hw *hw)
> }
> }
>
> - if (unlikely(!clk->enable_reg)) {
> + if (unlikely(IS_ERR(clk->enable_reg))) {
IS_ERR() already has an unlikely inside it, so the unlikely is
redundant here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-02 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 22:37 [PATCH] clk: ti: dflt: fix enable_reg validity check Suman Anna
2015-09-29 22:37 ` Suman Anna
2015-10-02 6:36 ` Tero Kristo
2015-10-02 6:36 ` Tero Kristo
2015-10-02 18:21 ` Stephen Boyd [this message]
2015-10-02 18:45 ` Suman Anna
2015-10-02 18:45 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002182133.GO12338@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.