All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: Peter Bergner <bergner@vnet.ibm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Laura Abbott <labbott@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Missing operand for tlbie instruction on Power7
Date: Fri, 2 Oct 2015 17:00:51 -0500	[thread overview]
Message-ID: <20151002220051.GA26712@gate.crashing.org> (raw)
In-Reply-To: <CAOJe8K2GOsBk=CcWaZqq9KN=McLad97BP6ZhEdRB7i2Ag4csOg@mail.gmail.com>

On Sat, Oct 03, 2015 at 12:37:35AM +0300, Denis Kirjanov wrote:
> >> -0:     tlbie   r4;                             \
> >> +0:     tlbie   r4, 0;                          \
> >
> > This isn't correct.  With POWER7 and later (which this compile
> > is, since it's on LE), the tlbie instruction takes two register
> > operands:
> >
> >     tlbie RB, RS
> >
> > The tlbie instruction on pre POWER7 cpus had one required register
> > operand (RB) and an optional second L operand, where if you omitted
> > it, it was the same as using "0":
> >
> >     tlbie RB, L
> >
> > This is a POWER7 and later build, so your change which adds the "0"
> > above is really adding r0 for RS.  The new tlbie instruction doesn't
> > treat r0 specially, so you'll be using whatever random bits which
> > happen to be in r0 which I don't think that is what you want.
> 
> Ok, than we can just zero out r5 for example and use it in tlbie as RS,
> right?

That won't assemble _unless_ your assembler is in POWER7 mode.  It also
won't do the right thing at run time on older machines.

Where is this tlbia macro used at all, for 64-bit machines?


Segher

  reply	other threads:[~2015-10-02 22:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 15:43 Missing operand for tlbie instruction on Power7 Laura Abbott
2015-10-02 19:03 ` Denis Kirjanov
2015-10-02 20:15   ` Peter Bergner
2015-10-02 21:37     ` Denis Kirjanov
2015-10-02 22:00       ` Segher Boessenkool [this message]
2015-10-02 22:12         ` Laura Abbott
2015-10-03  2:24         ` Peter Bergner
2015-10-04  0:00           ` Segher Boessenkool
2015-10-06  0:39             ` Laura Abbott
2015-10-06  3:35 ` Michael Ellerman
2015-10-06 18:25   ` Laura Abbott
2015-10-07  6:00     ` Michael Ellerman
2015-10-07  7:19       ` Segher Boessenkool
2015-10-07  9:13         ` Michael Ellerman
2015-10-07 14:31           ` Josh Boyer
2015-10-08  0:10             ` Michael Ellerman
2015-10-08  0:15               ` Josh Boyer
2015-10-08  0:38                 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002220051.GA26712@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=bergner@vnet.ibm.com \
    --cc=kda@linux-powerpc.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.