All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-kernel@vger.kernel.org,
	Alexei Starovoitov <ast@plumgrid.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] ebpf, events: make it actually more configurable
Date: Sat, 3 Oct 2015 08:37:15 +0200	[thread overview]
Message-ID: <20151003063715.GA22713@gmail.com> (raw)
In-Reply-To: <a0cfcb14b6aefee716ff34f3829f7d17948d5a2e.1443799500.git.daniel@iogearbox.net>


* Daniel Borkmann <daniel@iogearbox.net> wrote:

> While testing some other BPF issue, I realized that BPF_EVENTS is
> actually not accessible through menuconfig because of a missing
> description that needs to be attached to the bool. After the patch
> the entry shows up in menuconfig and can be enabled/disabled from
> there.

Yeah, so the principle is the following: the main configuration option for it is 
BPF_SYSCALL. The BPF_EVENTS is an internal detail, always enabled when possible, 
and we make it so that if the BPF syscall is enabled, we'll enable the perf 
integration if all the must-have components are in place:

>  	depends on KPROBE_EVENT || UPROBE_EVENT
>  	default y

So this is intentional.

Unless your suggestion is to also enable it when neither KPROBE_EVENT nor 
UPROBE_EVENT are defined. Does that make sense?

Thanks,

	Ingo

  reply	other threads:[~2015-10-03  6:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 15:43 [PATCH] ebpf, events: make it actually more configurable Daniel Borkmann
2015-10-03  6:37 ` Ingo Molnar [this message]
2015-10-03  7:42   ` Daniel Borkmann
2015-10-03  8:24     ` Ingo Molnar
2015-10-04 22:16       ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151003063715.GA22713@gmail.com \
    --to=mingo@kernel.org \
    --cc=ast@plumgrid.com \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.