Re: [Outreachy kernel] [PATCH v4] Staging: olpc_dcon: Replace timespec with ktime_t

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Sat, Oct 03, 2015 at 08:05:16AM +0200, Ksenija Stanojević wrote:
> Hi Sudip,
> 
> On Sat, Oct 3, 2015 at 7:59 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Fri, Oct 02, 2015 at 07:24:05PM +0200, Ksenija Stanojevic wrote:
> >> Struct timespec will overflow in year 2038, here it will not cause an
> >> overflow because it is used with timespec_sub, but still has to be
> >> removed as part of y2038 changes. Replace it with ktime_t. Also use
> >> monotonic instead of real-time by replacing functions getnstimeofday
> >> with ktime_get.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >> Changes in v4:
> >>       -fix checkpatch.pl errors/warnings introduced by changes made
> > You missed one more checkpatch warning.
> >>        in v3.
> > <snip>
> >> +             delta_t = ktime_sub(now, dcon->load_time);
> >> +             if (ktime_to_ns(delta_t) > NSEC_PER_MSEC * 20) {
> >>                       break;
> >>               }
> > braces are not required for single statement if block.
> 
> I didn't know whether snould I change that or not, because that change is maybe
> for another  patch?
> Should I fix it  and resend?
Not required. Just pointed that out. Resend if Greg asks for it.

regards
sudip