From: Andrei Gherzan <andrei@gherzan.ro>
To: Jonathan Liu <net147@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
Date: Sun, 4 Oct 2015 02:04:19 +0200 [thread overview]
Message-ID: <20151004000419.GA28229@resin> (raw)
In-Reply-To: <561067E2.5020807@gmail.com>
On Sun, Oct 04, 2015 at 10:42:26AM +1100, Jonathan Liu wrote:
> On 22/08/2015 6:25 PM, Jonathan Liu wrote:
> >SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
> >
> >Signed-off-by: Jonathan Liu <net147@gmail.com>
> >---
> > recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> >index d60a3e9..ef98421 100644
> >--- a/recipes-kernel/linux/linux-raspberrypi.inc
> >+++ b/recipes-kernel/linux/linux-raspberrypi.inc
> >@@ -12,7 +12,8 @@ SRC_URI += " \
> > COMPATIBLE_MACHINE = "raspberrypi"
> >-PV = "${LINUX_VERSION}+git${SRCREV}"
> >+PV = "${LINUX_VERSION}+git${SRCPV}"
> >+PR = "r1"
Why would you want to bump PR? It will eventually end up being the same value,
right? The PV change makes sense and is a good idea. And even if it's not the
same value will trigger a new build cause PV will change.
> > # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
> > KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
> Bump.
>
> Regards,
> Jonathan
--
Andrei Gherzan
next prev parent reply other threads:[~2015-10-04 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 8:25 [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV Jonathan Liu
2015-10-03 23:42 ` Jonathan Liu
2015-10-04 0:04 ` Andrei Gherzan [this message]
2015-10-04 1:17 ` Jonathan Liu
2015-10-04 1:36 ` Jonathan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004000419.GA28229@resin \
--to=andrei@gherzan.ro \
--cc=net147@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.