From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Chandra S Gorentla <csgorentla@gmail.com>,
johnny.kim@atmel.com, rachel.kim@atmel.com, chris.park@atmel.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases
Date: Sun, 4 Oct 2015 12:16:31 +0300 [thread overview]
Message-ID: <20151004091631.GS7289@mwanda> (raw)
In-Reply-To: <20151004084457.GB24589@kroah.com>
On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote:
> Aren't you now leaking memory as you aren't freeing pstrMessage and the
> buffer on the "normal" return path?
It's supposed to. It's a bug fix. I explained to him in the first
version that his changelog sucks.
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-04 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 9:27 [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section Chandra S Gorentla
2015-10-03 9:27 ` [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases Chandra S Gorentla
2015-10-04 8:44 ` Greg KH
2015-10-04 9:16 ` Dan Carpenter [this message]
2015-10-04 10:10 ` Greg KH
2015-10-04 10:28 ` Chandra Gorentla
2015-10-05 3:23 ` Tony Cho
2015-10-04 8:43 ` [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section Greg KH
2015-10-04 10:07 ` Chandra Gorentla
2015-10-04 10:19 ` Greg KH
2015-10-05 3:23 ` Tony Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004091631.GS7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=csgorentla@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.