From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Sun, 4 Oct 2015 12:04:21 +0100 Subject: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure In-Reply-To: <1443616591-17867-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1443616298-17389-1-git-send-email-srinivas.kandagatla@linaro.org> <1443616591-17867-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <20151004110421.GB7110@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 30, 2015 at 01:36:31PM +0100, Srinivas Kandagatla wrote: > From: Maxime Ripard > > The sunxi_sid driver doesn't check for kmalloc return status before > derefencing the returned pointer, which could lead to a NULL pointer > dereference if kmalloc failed. Check for its return code to make sure it > deosn't happen. > > Reported-by: Dan Carpenter > Signed-off-by: Maxime Ripard > --- > drivers/nvmem/sunxi_sid.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) No signed-off-by: from you on this patch? :( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751528AbbJDLE3 (ORCPT ); Sun, 4 Oct 2015 07:04:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37738 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbbJDLE2 (ORCPT ); Sun, 4 Oct 2015 07:04:28 -0400 Date: Sun, 4 Oct 2015 12:04:21 +0100 From: Greg KH To: Srinivas Kandagatla Cc: maxime.ripard@free-electrons.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure Message-ID: <20151004110421.GB7110@kroah.com> References: <1443616298-17389-1-git-send-email-srinivas.kandagatla@linaro.org> <1443616591-17867-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443616591-17867-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 01:36:31PM +0100, Srinivas Kandagatla wrote: > From: Maxime Ripard > > The sunxi_sid driver doesn't check for kmalloc return status before > derefencing the returned pointer, which could lead to a NULL pointer > dereference if kmalloc failed. Check for its return code to make sure it > deosn't happen. > > Reported-by: Dan Carpenter > Signed-off-by: Maxime Ripard > --- > drivers/nvmem/sunxi_sid.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) No signed-off-by: from you on this patch? :(