From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output
Date: Sun, 4 Oct 2015 12:19:06 +0100 [thread overview]
Message-ID: <20151004111906.GA23333@kroah.com> (raw)
In-Reply-To: <1442822295-5111-1-git-send-email-tomas.winkler@intel.com>
On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> From: Alexander Kuleshov <kuleshovmail@gmail.com>
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> V2: fixed author address
>
> drivers/misc/mei/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> index 4b469cf9e60f..c157f0ba575c 100644
> --- a/drivers/misc/mei/debugfs.c
> +++ b/drivers/misc/mei/debugfs.c
> @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
> f = debugfs_create_file("active", S_IRUSR, dir,
> dev, &mei_dbgfs_fops_active);
> if (!f) {
> - dev_err(dev->dev, "meclients: registration failed\n");
> + dev_err(dev->dev, "active: registration failed\n");
> goto err;
You should never care if a debugfs call fails or not. Also, this will
"fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
using the api wrong :(
greg k-h
next prev parent reply other threads:[~2015-10-04 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 7:58 [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Tomas Winkler
2015-10-04 11:19 ` Greg Kroah-Hartman [this message]
2015-10-05 14:47 ` Winkler, Tomas
2015-10-05 15:30 ` Greg Kroah-Hartman
2015-10-06 8:46 ` Winkler, Tomas
2015-10-25 12:45 ` Winkler, Tomas
2015-10-25 16:56 ` 'Greg Kroah-Hartman'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004111906.GA23333@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.