* [PATCH] misc: mic: replace kfree with put_device
@ 2015-09-29 16:58 Geliang Tang
2015-10-04 11:57 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Geliang Tang @ 2015-09-29 16:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ashutosh Dixit, Sudeep Dutt, Nikhil Rao
Cc: Geliang Tang, linux-kernel
Handle a failed device_register(), replace kfree() with put_device(),
which will call mbus_release_dev() or scif_release_dev().
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/misc/mic/bus/mic_bus.c | 2 +-
drivers/misc/mic/bus/scif_bus.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mic/bus/mic_bus.c b/drivers/misc/mic/bus/mic_bus.c
index 961ae90..a25be8d 100644
--- a/drivers/misc/mic/bus/mic_bus.c
+++ b/drivers/misc/mic/bus/mic_bus.c
@@ -185,7 +185,7 @@ mbus_register_device(struct device *pdev, int id, struct dma_map_ops *dma_ops,
ida_remove:
ida_simple_remove(&mbus_index_ida, mbdev->index);
free_mbdev:
- kfree(mbdev);
+ put_device(&mbdev->dev);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(mbus_register_device);
diff --git a/drivers/misc/mic/bus/scif_bus.c b/drivers/misc/mic/bus/scif_bus.c
index 2da7cee..8972ae7 100644
--- a/drivers/misc/mic/bus/scif_bus.c
+++ b/drivers/misc/mic/bus/scif_bus.c
@@ -181,7 +181,7 @@ scif_register_device(struct device *pdev, int id, struct dma_map_ops *dma_ops,
goto free_sdev;
return sdev;
free_sdev:
- kfree(sdev);
+ put_device(&sdev->dev);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(scif_register_device);
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: mic: replace kfree with put_device
2015-09-29 16:58 [PATCH] misc: mic: replace kfree with put_device Geliang Tang
@ 2015-10-04 11:57 ` Greg Kroah-Hartman
2015-10-05 0:33 ` [PATCH v2] " Geliang Tang
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2015-10-04 11:57 UTC (permalink / raw)
To: Geliang Tang; +Cc: Ashutosh Dixit, Sudeep Dutt, Nikhil Rao, linux-kernel
On Wed, Sep 30, 2015 at 12:58:22AM +0800, Geliang Tang wrote:
> Handle a failed device_register(), replace kfree() with put_device(),
> which will call mbus_release_dev() or scif_release_dev().
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/misc/mic/bus/mic_bus.c | 2 +-
> drivers/misc/mic/bus/scif_bus.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Due to the recent changes in this driver, this patch doesn't apply
anymore. Can you please refresh it and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] misc: mic: replace kfree with put_device
2015-10-04 11:57 ` Greg Kroah-Hartman
@ 2015-10-05 0:33 ` Geliang Tang
2015-10-11 21:12 ` Ashutosh Dixit
0 siblings, 1 reply; 4+ messages in thread
From: Geliang Tang @ 2015-10-05 0:33 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ashutosh Dixit, Sudeep Dutt, Nikhil Rao
Cc: Geliang Tang, linux-kernel
Handle a failed device_register(), replace kfree() with put_device(),
which will call mbus_release_dev() or scif_release_dev().
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
Changes in v2:
- Just refresh this patch.
---
drivers/misc/mic/bus/mic_bus.c | 2 +-
drivers/misc/mic/bus/scif_bus.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mic/bus/mic_bus.c b/drivers/misc/mic/bus/mic_bus.c
index c64955d..be37890 100644
--- a/drivers/misc/mic/bus/mic_bus.c
+++ b/drivers/misc/mic/bus/mic_bus.c
@@ -175,7 +175,7 @@ mbus_register_device(struct device *pdev, int id, struct dma_map_ops *dma_ops,
goto free_mbdev;
return mbdev;
free_mbdev:
- kfree(mbdev);
+ put_device(&mbdev->dev);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(mbus_register_device);
diff --git a/drivers/misc/mic/bus/scif_bus.c b/drivers/misc/mic/bus/scif_bus.c
index fd27021..ff6e01c 100644
--- a/drivers/misc/mic/bus/scif_bus.c
+++ b/drivers/misc/mic/bus/scif_bus.c
@@ -180,7 +180,7 @@ scif_register_device(struct device *pdev, int id, struct dma_map_ops *dma_ops,
goto free_sdev;
return sdev;
free_sdev:
- kfree(sdev);
+ put_device(&sdev->dev);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(scif_register_device);
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] misc: mic: replace kfree with put_device
2015-10-05 0:33 ` [PATCH v2] " Geliang Tang
@ 2015-10-11 21:12 ` Ashutosh Dixit
0 siblings, 0 replies; 4+ messages in thread
From: Ashutosh Dixit @ 2015-10-11 21:12 UTC (permalink / raw)
To: Geliang Tang
Cc: Greg Kroah-Hartman, Dutt, Sudeep, Rao, Nikhil,
linux-kernel@vger.kernel.org
On Sun, Oct 04 2015 at 05:33:47 PM, Geliang Tang <geliangtang@163.com> wrote:
> Handle a failed device_register(), replace kfree() with put_device(),
> which will call mbus_release_dev() or scif_release_dev().
Could you add the same change to cosm_bus.c too in the same path and
resubmit the patch. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-11 21:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-29 16:58 [PATCH] misc: mic: replace kfree with put_device Geliang Tang
2015-10-04 11:57 ` Greg Kroah-Hartman
2015-10-05 0:33 ` [PATCH v2] " Geliang Tang
2015-10-11 21:12 ` Ashutosh Dixit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.