From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbbJDQKU (ORCPT ); Sun, 4 Oct 2015 12:10:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42553 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbbJDQKT (ORCPT ); Sun, 4 Oct 2015 12:10:19 -0400 Date: Sun, 4 Oct 2015 17:10:16 +0100 From: Greg KH To: Alexander Kapshuk Cc: linux-kernel Subject: Re: [PATCH 1/24] ver_linux: echo.patch Message-ID: <20151004161016.GA24058@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Your subject is really "odd", it doesn't really describe what you are doing in a single line, it just has a file name in it :( What did you use to generate these? I got a few duplicates, and there isn't a "leading" 0 for the first 9 patches. git can spit these out correctly very simply, I recommend using that in the future. On Sat, Oct 03, 2015 at 03:57:08PM +0300, Alexander Kapshuk wrote: > While not a problem in itself, I was not sure why 'echo space' was used. > Not being aware of any immediate benefits to this, I thought using > 'echo' by itself would suffice in printing a newline, which I believe is > the desired behaviour. > > Signed-off-by: Alexander Kapshuk > --- > --- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300 > +++ linux/scripts/ver_linux 2015-10-03 13:43:38.587271851 +0300 > @@ -6,10 +6,10 @@ > # > echo 'If some fields are empty or look unusual you may have an old version.' > echo 'Compare to the current minimal requirements in Documentation/Changes.' > -echo ' ' > +echo > > uname -a > -echo ' ' > +echo Can you respin these patches with correct subject lines, based on this, and the other feedback you have gotten and resend them? thanks, greg k-h