From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id BEBEFE00E98; Mon, 5 Oct 2015 01:22:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.115 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 96DB7E00A26 for ; Mon, 5 Oct 2015 01:22:03 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 05 Oct 2015 01:22:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,637,1437462000"; d="scan'208";a="784586049" Received: from linux.intel.com ([10.23.219.25]) by orsmga001.jf.intel.com with ESMTP; 05 Oct 2015 01:22:03 -0700 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id E7EB66A4083; Mon, 5 Oct 2015 01:21:05 -0700 (PDT) Date: Mon, 5 Oct 2015 11:21:58 +0300 From: Ed Bartosh To: brian avery Message-ID: <20151005082158.GA30642@linux.intel.com> References: MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: toaster@yoctoproject.org Subject: Re: [PATCH 0/4] remove startup questions v2 X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 08:22:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The patchset looks good to me. Acked-by: Ed Bartosh On Fri, Oct 02, 2015 at 10:30:16AM -0700, brian avery wrote: > This is v2 of my easier startup patch. I addressed most of Ed's comments. > > This one , > splits into more commits. The checksettings commit is still big but would take a > fair amount of time to break into anything that would run separately. > > did some pylint fixes. > > check for the config file and exits if missing. > > made some code more explicit. > > got rid of most of the trailing white spaces (one is not in the git tree but is in the patch. no idea why) > > -b > > The following changes since commit af1e3160922a30b8a538959335a5f8945f2f3549: > > toaster: Remove project name from latest project builds (2015-10-02 14:44:14 +0100) > > are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib bavery/toaster/startup_simplification_8217_v2 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/startup_simplification_8217_v2 > > brian avery (4): > toaster: removed superuser question from startup > toaster: remove layer and build dir interactive questions > toaster: check for configuration file and exit if not found > toaster: get rid of interactivity in bldcontrol > > bitbake/bin/toaster | 38 +++++- > .../management/commands/checksettings.py | 138 ++++++--------------- > 2 files changed, 69 insertions(+), 107 deletions(-) > > -- > 1.9.1 > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster -- -- Regards, Ed