From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Feng Gao <gfree.wind@outlook.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] netfilter: ftp: Check data size before copy them into FTP buffer
Date: Mon, 5 Oct 2015 11:07:31 +0200 [thread overview]
Message-ID: <20151005090731.GA1806@salvia> (raw)
In-Reply-To: <alpine.LSU.2.20.1510042338260.19792@nerf40.vanv.qr>
On Sun, Oct 04, 2015 at 11:38:59PM +0200, Jan Engelhardt wrote:
> On Sunday 2015-10-04 22:16, Pablo Neira Ayuso wrote:
>
> >On Tue, Sep 29, 2015 at 04:49:32PM +0800, Feng Gao wrote:
> >> When TCP endpoint supports the windows scale option, the data size could
> >> be more than 65536 easily. And there are some network interface features
> >> which could aggregate multiple packets. So we need to check the datalen
> >> before copy data into the FTP buffer.
> >
> >I don't think you can go over the maximum IPv4/IPv6 packet length with
> >aggregation.
>
> But there are jumbo frames known to IPv6, at least in principle. Dunno
> if GRO/TSO/.. do that, though.
I didn't find any code to aggregate IPv6 jumbograms packets at quick
glance. Actually, this needs changes in the existing transport
protocols to work: https://tools.ietf.org/html/rfc2675
next prev parent reply other threads:[~2015-10-05 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 8:49 [PATCH 1/1] netfilter: ftp: Check data size before copy them into FTP buffer Feng Gao
2015-10-04 20:16 ` Pablo Neira Ayuso
2015-10-04 21:38 ` Jan Engelhardt
2015-10-05 9:07 ` Pablo Neira Ayuso [this message]
2015-10-08 13:32 ` Feng Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005090731.GA1806@salvia \
--to=pablo@netfilter.org \
--cc=gfree.wind@outlook.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.