All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 1/2] Staging: wilc1000: wilc_wfi_cfgoperations: Replace memset with eth_zero_addr
Date: Mon, 5 Oct 2015 10:53:02 +0100	[thread overview]
Message-ID: <20151005095302.GA5600@kroah.com> (raw)
In-Reply-To: <1444026634-14551-2-git-send-email-shraddha.6596@gmail.com>

On Mon, Oct 05, 2015 at 12:00:33PM +0530, Shraddha Barke wrote:
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.

How do you know that this is safe to do?  You need to document the heck
out of this and why you know this is ok.  See other patches that do this
for examples of what you need to do.

thanks,

greg k-h


  reply	other threads:[~2015-10-05  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05  6:30 [PATCH v3 0/2] Replace memset with eth_zero_addr Shraddha Barke
2015-10-05  6:30 ` [PATCH v3 1/2] Staging: wilc1000: wilc_wfi_cfgoperations: " Shraddha Barke
2015-10-05  9:53   ` Greg KH [this message]
2015-10-05 10:28     ` [Outreachy kernel] " Julia Lawall
2015-10-05 10:44       ` Greg KH
2015-10-05 10:49         ` Julia Lawall
2015-10-05 11:06           ` Greg KH
2015-10-05  6:30 ` [PATCH v3 2/2] Staging: wilc1000: host_interface: " Shraddha Barke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005095302.GA5600@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shraddha.6596@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.