From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized Date: Mon, 5 Oct 2015 12:03:55 +0200 Message-ID: <20151005100354.GB12506@8bytes.org> References: <20150923160621.GA3446@pd.tnic> <20150923161839.GB3446@pd.tnic> <20150926164651.GA3640@pd.tnic> <560A50DC.1040505@linux.intel.com> <20150929105138.GA12037@nazgul.tnic> <560B9323.6000309@linux.intel.com> <20150930124432.GS3036@8bytes.org> <560C153C.10600@linux.intel.com> <20150930173619.GA3826@pd.tnic> <560F8583.2010403@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD9F96E3B7 for ; Mon, 5 Oct 2015 03:03:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <560F8583.2010403@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jiang Liu Cc: lkml , Maling list - DRI developers , Borislav Petkov , Bjorn Helgaas , Alex Deucher , Thomas Gleixner , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org SGkgSmlhbmcsCgpPbiBTYXQsIE9jdCAwMywgMjAxNSBhdCAwMzozNjozNVBNICswODAwLCBKaWFu ZyBMaXUgd3JvdGU6Cj4gU28gdG8gc3VtbWFyeSwgSSB0aGluayB3ZSBvbmx5IG5lZWQgZm9sbG93 aW5nIGNoYW5nZSB0byBmaXggdGhlCj4gcmVncmVzc2lvbjoKPiAgaW50IHBjaWJpb3NfYWxsb2Nf aXJxKHN0cnVjdCBwY2lfZGV2ICpkZXYpCj4gIHsKPiArCWlmIChwY2lfZGV2X21zaV9lbmFibGVk KGRldikpCj4gKwkJcmV0dXJuIC1FQlVTWTsKPiAKPiBXaGF0IGRvIHlvdSB0aGluaz8KClllcywg dGhhdCB3b3JrcyB0b28gYW5kIGhhcyB0aGUgYWRkZWQgYmVuZWZpdCB0aGF0IG5vIGRyaXZlciBj YW4gYXR0YWNoCnRvIHRoZSBpb21tdSBkZXZpY2UgYW5kIGdldCBpbiB0aGUgd2F5IG9mIHRoZSBk cml2ZXIuCgpXaWxsIHlvdSBzZW5kIHRoZSBwYXRjaCBmb3IgdGhpcyBjaGFuZ2Ugb3Igc2hvdWxk IEkgZG8gaXQ/CgoKCglKb2VyZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbJEKD5 (ORCPT ); Mon, 5 Oct 2015 06:03:57 -0400 Received: from 8bytes.org ([81.169.241.247]:52594 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbbJEKD4 (ORCPT ); Mon, 5 Oct 2015 06:03:56 -0400 Date: Mon, 5 Oct 2015 12:03:55 +0200 From: Joerg Roedel To: Jiang Liu Cc: Borislav Petkov , Daniel Vetter , Thomas Gleixner , Bjorn Helgaas , Alex Deucher , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Maling list - DRI developers , lkml Subject: Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized Message-ID: <20151005100354.GB12506@8bytes.org> References: <20150923160621.GA3446@pd.tnic> <20150923161839.GB3446@pd.tnic> <20150926164651.GA3640@pd.tnic> <560A50DC.1040505@linux.intel.com> <20150929105138.GA12037@nazgul.tnic> <560B9323.6000309@linux.intel.com> <20150930124432.GS3036@8bytes.org> <560C153C.10600@linux.intel.com> <20150930173619.GA3826@pd.tnic> <560F8583.2010403@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560F8583.2010403@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiang, On Sat, Oct 03, 2015 at 03:36:35PM +0800, Jiang Liu wrote: > So to summary, I think we only need following change to fix the > regression: > int pcibios_alloc_irq(struct pci_dev *dev) > { > + if (pci_dev_msi_enabled(dev)) > + return -EBUSY; > > What do you think? Yes, that works too and has the added benefit that no driver can attach to the iommu device and get in the way of the driver. Will you send the patch for this change or should I do it? Joerg